Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Enhancement ] Search bar should not be displayed when there is no Trusted Application added #95911

Closed
2 tasks
muskangulati-qasource opened this issue Mar 31, 2021 · 5 comments · Fixed by #100853
Assignees
Labels
enhancement New value added to drive a business result NeededFor:Onboarding and Lifecycle Mgt OLM Sprint QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0

Comments

@muskangulati-qasource
Copy link

muskangulati-qasource commented Mar 31, 2021

Describe the feature
Search bar should not be displayed when there is no Trusted Application added

Build Details:

Version: 7.13.0-SNAPSHOT
Commit: 0d8b13054b96847a3862f025126946f381725230
Build number: 39941
Artifact: https://artifacts-api.elastic.co/v1/search/7.13.0-SNAPSHOT

Preconditions

  1. Elastic 7.13.0 environment should be deployed

Steps to Reproduce

  1. Navigate to the Administration Tab.
  2. Click on the Trusted Applications tab.
  3. Search anything when there is no value added to the trusted applications list.
  4. Observe that the UI does not show any message for the value not found

AC:

  • When no Trusted App entries exist, the search bar should not be visible, we should only see the empty state.
  • When we use the search bar and we return no Trusted App results, the search bar should still be visible.

Screenshot

  • The initial UI
    TA1

  • UI when the user searches randomly when there is no Trusted Application added
    TA2

  • UI when the user searches for some unavailable value when one or more Trusted Application values are added to the list
    TA3

@muskangulati-qasource muskangulati-qasource added enhancement New value added to drive a business result Team:Defend Workflows “EDR Workflows” sub-team of Security Solution NeededFor:Onboarding and Lifecycle Mgt v7.13.0 labels Mar 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@manishgupta-qasource
Copy link

Reviewed & assigned to @kevinlog

@kevinlog
Copy link
Contributor

@caitlinbetz @bfishel how do you feel about this one? Should we hide the bar before there are entries added?

@caitlinbetz
Copy link

@kevinlog I don't think this is a huge deal - I just checked and looks like its the same on the Cases page.
But @bfishel let me know if you feel differently.

@muskangulati-qasource
Copy link
Author

Hi @kevinlog,

We tested this ticket on the latest 7.14.0-SNAPSHOT build & found that issue is now fixed. Please find below the testing details:

Build Details

VERSION: 7.14.0-SNAPSHOT
BUILD: 41403
COMMIT: 4f0781737cdb5cf9b5dfa624368b4306b5d6bcb0
ARTIFACT: https://artifacts-api.elastic.co/v1/search/7.14.0-SNAPSHOT

Screenshot
TrustedApplications

Hence, we are closing this ticket & marking it as "Validated".

Thanks!!

@muskangulati-qasource muskangulati-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result NeededFor:Onboarding and Lifecycle Mgt OLM Sprint QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0
Projects
None yet
6 participants