Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Runtime field editor] Preview field against cluster data #101398

Merged
merged 46 commits into from
Jun 22, 2021
Merged

[Runtime field editor] Preview field against cluster data #101398

merged 46 commits into from
Jun 22, 2021

Commits on Jun 4, 2021

  1. Add field preview header and empty prompt

    @sebelga
    sebelga committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    17f94dc View commit details
    Browse the repository at this point in the history

  2. Add preview document navigation

    @sebelga
    sebelga committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    e96e33f View commit details
    Browse the repository at this point in the history

  3. Add basic error handling when fetching documents

    @sebelga
    sebelga committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    cd80e34 View commit details
    Browse the repository at this point in the history

  4. Add field list and field list item

    @sebelga
    sebelga committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    9648e3e View commit details
    Browse the repository at this point in the history

  5. Use virtual list to render fields

    @sebelga
    sebelga committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    94aaf37 View commit details
    Browse the repository at this point in the history

  6. Expose panel height to consumers

    @sebelga
    sebelga committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    d265e1b View commit details
    Browse the repository at this point in the history

  7. Make virtual field list height dynamic

    @sebelga
    sebelga committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    60579cd View commit details
    Browse the repository at this point in the history

  8. Move filtering of fields to Preview component

    @sebelga
    sebelga committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    b6b0eb6 View commit details
    Browse the repository at this point in the history

  9. Render current field being created

    @sebelga
    sebelga committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    17c9a22 View commit details
    Browse the repository at this point in the history

  10. Add updating preview indicator in header

    @sebelga
    sebelga committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    9f88c22 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Update field list rendering

    @sebelga
    sebelga committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    a8d79a0 View commit details
    Browse the repository at this point in the history

  2. Add focus to the field editor flyout

    @sebelga
    sebelga committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    6732fdd View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @sebelga
    sebelga committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    c31b315 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Set fixed width to panel and move preview to the right

    @sebelga
    sebelga committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    e5395a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. [Form lib] Add useFormIsModified() hook

    @sebelga
    sebelga committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    f9a6fad View commit details
    Browse the repository at this point in the history

  2. Hide flyout close button and show confirm modal when cancel

    @sebelga
    sebelga committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    5fea64e View commit details
    Browse the repository at this point in the history

  3. Reduce list item height + bolding field being previewed

    @sebelga
    sebelga committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    64de3e8 View commit details
    Browse the repository at this point in the history

  4. Show _source value when no script is provided

    @sebelga
    sebelga committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    3e31852 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @sebelga
    sebelga committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    5b09833 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Refactor form lib UseField test

    @sebelga
    sebelga committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    798d4a9 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Michail Yasonik <[email protected]>
    @sebelga @myasonik
    sebelga and myasonik authored Jun 16, 2021
    Configuration menu
    Copy the full SHA
    e581514 View commit details
    Browse the repository at this point in the history

  3. Use better naming for painless error testBed

    @sebelga
    sebelga committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    97c18a2 View commit details
    Browse the repository at this point in the history

  4. Address CR changes

    @sebelga
    sebelga committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    4c05e3a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'runtime-field-editor/preview-from-cluster-2' of github.… 

    …com:sebelga/kibana into runtime-field-editor/preview-from-cluster-2
    @sebelga
    sebelga committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    a7990ce View commit details
    Browse the repository at this point in the history

  6. Revert changes to flyout_service and add missing prop

    @sebelga
    sebelga committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    1970973 View commit details
    Browse the repository at this point in the history

  7. Create component for confirm modal when saving field with name or typ… 

    …e change
    @sebelga
    sebelga committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    230100b View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Fix issue with stale state after fetching unknown document

    @sebelga
    sebelga committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    c5c5d73 View commit details
    Browse the repository at this point in the history

  2. Fix "updating..." state not being reset

    @sebelga
    sebelga committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    5e677e8 View commit details
    Browse the repository at this point in the history

  3. Move change to isModified into dedicated useEffect

    @sebelga
    sebelga committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    0386a9b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'runtime-field-editor/preview-field-workstream' into run… 

    …time-field-editor/preview-from-cluster-2
    @sebelga
    sebelga committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    6febb54 View commit details
    Browse the repository at this point in the history

  5. Fix TS issue

    @sebelga
    sebelga committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    bdbe126 View commit details
    Browse the repository at this point in the history

  6. Add missing core public API

    @sebelga
    sebelga committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    639b381 View commit details
    Browse the repository at this point in the history

  7. Fix TS issue

    @sebelga
    sebelga committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    871b065 View commit details
    Browse the repository at this point in the history

  8. Update a11y tests

    @sebelga
    sebelga committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    751a0d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Refactor logic to fetch document to fix tests

    @sebelga
    sebelga committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    7b69cc4 View commit details
    Browse the repository at this point in the history

  2. Discard _meta form field to detect if the form has been modified

    @sebelga
    sebelga committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    2d3e21e View commit details
    Browse the repository at this point in the history

  3. Address CR changes

    @sebelga
    sebelga committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    2072ebe View commit details
    Browse the repository at this point in the history

  4. Fix functional test

    @sebelga
    sebelga committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    ba0605a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'runtime-field-editor/preview-field-workstream' into run… 

    …time-field-editor/preview-from-cluster-2
    @sebelga
    sebelga committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    83007f7 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Merge branch 'runtime-field-editor/preview-field-workstream' into run… 

    …time-field-editor/preview-from-cluster-2
    @sebelga
    sebelga committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    3be4625 View commit details
    Browse the repository at this point in the history

  2. Improve logic to set form isModified for fields removed from the DOM

    @sebelga
    sebelga committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    ca73545 View commit details
    Browse the repository at this point in the history

  3. Display confirm modal when clicking outside the flyout

    @sebelga
    sebelga committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    8f33eb0 View commit details
    Browse the repository at this point in the history

  4. Add "onClose" public API

    @sebelga
    sebelga committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    f7cf0ed View commit details
    Browse the repository at this point in the history

  5. Refactor overlay onClose option to provide the flyout instance

    @sebelga
    sebelga committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    6b4b8d1 View commit details
    Browse the repository at this point in the history

  6. Add doc for overlay onClose option

    @sebelga
    sebelga committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    eea8a9a View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Merge branch 'runtime-field-editor/preview-field-workstream' into run… 

    …time-field-editor/preview-from-cluster-2
    @sebelga
    sebelga committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    400550f View commit details
    Browse the repository at this point in the history