Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix SVG rendered agent icon in Service Map, and improve storybook for icons #102182

Merged
merged 3 commits into from
Jun 17, 2021
Merged

[APM] Fix SVG rendered agent icon in Service Map, and improve storybook for icons #102182

merged 3 commits into from
Jun 17, 2021

Conversation

sorenlouv
Copy link
Member

Agent icons

image

Span icons

image

@sorenlouv sorenlouv requested a review from a team as a code owner June 15, 2021 10:20
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv mentioned this pull request Jun 15, 2021
Merged
@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 15, 2021
@sorenlouv
Copy link
Member Author

jenkins run the e2e

@sorenlouv sorenlouv changed the title [APM] Fix icon stories [APM] Fix SVG rendered agent icon in Service Map, and improve storybook for icons Jun 16, 2021
cauemarcondes
cauemarcondes approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x-pack/plugins/apm/public/components/shared/span_icon/span_icon.stories.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/shared/span_icon/span_icon.stories.tsx Outdated Show resolved Hide resolved
@sorenlouv sorenlouv enabled auto-merge (squash) June 16, 2021 21:01
@sorenlouv
Copy link
Member Author

retest

1 similar comment
@sorenlouv
Copy link
Member Author

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1534 1536 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +8.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 17e264e into elastic:master Jun 17, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 17, 2021
@sorenlouv @kibanamachine
[APM] Fix SVG rendered agent icon in Service Map, and improve storybo…
af33b05 
…ok for icons (elastic#102182)
@kibanamachine kibanamachine mentioned this pull request Jun 17, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@sorenlouv sorenlouv deleted the fix-icon-stories branch June 17, 2021 10:42
kibanamachine added a commit that referenced this pull request Jun 17, 2021
@kibanamachine @sorenlouv
[APM] Fix SVG rendered agent icon in Service Map, and improve storybo…
bf7913d 
…ok for icons (#102182) (#102482)

Co-authored-by: Søren Louv-Jansen <[email protected]>
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Jun 18, 2021
@sorenlouv
[APM] Fix SVG rendered agent icon in Service Map, and improve storybo…
e52d435 
…ok for icons (elastic#102182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sorenlouv @elasticmachine @kibanamachine @cauemarcondes