Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.8] Force-upgrade all versions of minimist to ^1.2.5 #102243

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

watson
Copy link
Contributor

@watson watson commented Jun 15, 2021

A similar thing have been done in 7.x (see #60284), and it should be safe to do the same thing here.

@watson watson added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v6.8.17 labels Jun 15, 2021
@watson watson self-assigned this Jun 15, 2021
@watson watson requested a review from a team June 15, 2021 16:38
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for posterity, in the current 6.8 branch:

% yarn why minimist    
yarn why v1.22.10
[1/4] 🤔  Why do we have the module "minimist"...?
[2/4] 🚚  Initialising dependency graph...
warning Resolution field "[email protected]" is incompatible with requested version "[email protected]"
warning Resolution field "[email protected]" is incompatible with requested version "yargs-parser@^5.0.0"
warning Resolution field "[email protected]" is incompatible with requested version "[email protected]"
warning Resolution field "[email protected]" is incompatible with requested version "[email protected]"
warning Resolution field "[email protected]" is incompatible with requested version "schema-utils@^0.3.0"
warning Resolution field "[email protected]" is incompatible with requested version "[email protected]"
warning Resolution field "@types/[email protected]" is incompatible with requested version "@types/node@^14.14.10"
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "minimist"
info Reasons this module exists
   - "workspace-aggregator-9674edcd-0935-455f-abe8-f8cee80cf7b6" depends on it
   - Hoisted from "_project_#json5#minimist"
   - Hoisted from "_project_#ts-node#minimist"
   - Hoisted from "_project_#karma-mocha#minimist"
   - Hoisted from "_project_#handlebars#minimist"
   - Hoisted from "_project_#dateformat#meow#minimist"
   - Hoisted from "_project_#@kbn#pm#strong-log-transformer#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yeoman-generator#minimist"
   - Hoisted from "_project_#less#mkdirp#minimist"
   - Hoisted from "_project_#nock#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#pm#mkdirp#minimist"
   - Hoisted from "_project_#babel-loader#mkdirp#minimist"
   - Hoisted from "_project_#babel-register#mkdirp#minimist"
   - Hoisted from "_project_#cache-loader#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#es#mkdirp#minimist"
   - Hoisted from "_project_#backport#mkdirp#minimist"
   - Hoisted from "_project_#eslint#mkdirp#minimist"
   - Hoisted from "_project_#node-sass#mkdirp#minimist"
   - Hoisted from "_project_#ts-node#mkdirp#minimist"
   - Hoisted from "_project_#extract-zip#mkdirp#minimist"
   - Hoisted from "_project_#webpack#mkdirp#minimist"
   - Hoisted from "_project_#x-pack#mapbox-gl#geojson-rewind#minimist"
   - Hoisted from "_project_#x-pack#gulp-mocha#gulp-util#minimist"
   - Hoisted from "_project_#jest-cli#jest-haste-map#sane#minimist"
   - Hoisted from "_project_#@kbn#i18n#@babel#core#json5#minimist"
   - Hoisted from "_project_#fsevents#node-pre-gyp#rc#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yo#tabtab#minimist"
   - Hoisted from "_project_#karma-coverage#istanbul#mkdirp#minimist"
   - Hoisted from "_project_#tar#fstream#mkdirp#minimist"
   - Hoisted from "_project_#sass-lint#eslint#mkdirp#minimist"
   - Hoisted from "_project_#node-sass#node-gyp#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yeoman-generator#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#i18n#@babel#cli#mkdirp#minimist"
   - Hoisted from "_project_#terser-webpack-plugin#cacache#mkdirp#minimist"
   - Hoisted from "_project_#jest-cli#istanbul-api#mkdirp#minimist"
   - Hoisted from "_project_#jest-cli#istanbul-lib-source-maps#mkdirp#minimist"
   - Hoisted from "_project_#jest-cli#jest-snapshot#mkdirp#minimist"
   - Hoisted from "_project_#jest-cli#jest-util#mkdirp#minimist"
   - Hoisted from "_project_#re2#node-gyp#mkdirp#minimist"
   - Hoisted from "_project_#fsevents#node-pre-gyp#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#pm#cmd-shim#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yo#yosay#taketalk#minimist"
   - Hoisted from "_project_#@kbn#plugin-generator#sao#yarn-install#cac#minimist"
   - Hoisted from "_project_#@kbn#plugin-generator#sao#cac#minimost#minimist"
   - Hoisted from "_project_#jest-cli#jest-haste-map#sane#watch#minimist"
   - Hoisted from "_project_#makelogs#update-notifier#configstore#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yeoman-generator#mem-fs-editor#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#interpreter#copy-webpack-plugin#cacache#mkdirp#minimist"
   - Hoisted from "_project_#jest-cli#istanbul-api#istanbul-lib-report#mkdirp#minimist"
   - Hoisted from "_project_#terser-webpack-plugin#cacache#move-concurrently#mkdirp#minimist"
   - Hoisted from "_project_#@elastic#datemath#babel-cli#output-file-sync#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yo#tabtab#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#webpack-dev-server#webpack-dev-middleware#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#webpack-dev-server#portfinder#mkdirp#minimist"
   - Hoisted from "_project_#x-pack#babel-plugin-inline-react-svg#svgo#mkdirp#minimist"
   - Hoisted from "_project_#x-pack#turf#turf-isolines#turf-grid#turf-point#minimist"
   - Hoisted from "_project_#x-pack#pdfmake#linebreak#brfs#quote-stream#minimist"
   - Hoisted from "_project_#terser-webpack-plugin#cacache#move-concurrently#copy-concurrently#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#plugin-generator#sao#download-git-repo#download#mkdirp#minimist"
   - Hoisted from "_project_#eslint#file-entry-cache#flat-cache#write#mkdirp#minimist"
info Disk size without dependencies: "104KB"
info Disk size with unique dependencies: "104KB"
info Disk size with transitive dependencies: "104KB"
info Number of shared dependencies: 0
=> Found "mkdirp#[email protected]"
info This module exists because "_project_#mkdirp" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "72KB"
info Disk size with transitive dependencies: "72KB"
info Number of shared dependencies: 0
=> Found "mapbox-gl#[email protected]"
info This module exists because "_project_#x-pack#mapbox-gl" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "72KB"
info Disk size with transitive dependencies: "72KB"
info Number of shared dependencies: 0
=> Found "gonzales-pe-sl#[email protected]"
info This module exists because "_project_#sass-lint#gonzales-pe-sl" depends on it.
info Disk size without dependencies: "92KB"
info Disk size with unique dependencies: "92KB"
info Disk size with transitive dependencies: "92KB"
info Number of shared dependencies: 0
=> Found "glob-all#[email protected]"
info Reasons this module exists
   - "_project_#glob-all#yargs" depends on it
   - Hoisted from "_project_#glob-all#yargs#minimist"
info Disk size without dependencies: "80KB"
info Disk size with unique dependencies: "80KB"
info Disk size with transitive dependencies: "80KB"
info Number of shared dependencies: 0
=> Found "optimist#[email protected]"
info This module exists because "_project_#makelogs#optimist" depends on it.
info Disk size without dependencies: "80KB"
info Disk size with unique dependencies: "80KB"
info Disk size with transitive dependencies: "80KB"
info Number of shared dependencies: 0
=> Found "sharkdown#[email protected]"
info This module exists because "_project_#x-pack#mapbox-gl#geojson-rewind#sharkdown" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "72KB"
info Disk size with transitive dependencies: "72KB"
info Number of shared dependencies: 0
✨  Done in 1.28s.

I know in the linked PR you upgraded geojson-rewind from 0.4.1 to 0.5.0. The 6.8 branch is currently using version 0.3.0 though, so idk if it's safe to make the same upgrade.

@watson
Copy link
Contributor Author

watson commented Jun 16, 2021

@jportner the geojson-rewind we upgraded in 7.x was actually @mapbox/geojson-rewind. The geojson-rewind package in 6.8 does not have anything newer than what we already got, so we can't upgrade it as it's not a direct dependency (as it is in 7.x), but a sub-dependency of mapbox-gl

Update: Ok, I could actually update mapbox-gl from v0.52.0 to v0.53.1 (anything higher than that version will introduce breaking changes). This upgrade did change the dependency from geojson-rewind to @mapbox/geojson-rewind version 0.4.1. However, since it's still an indirect dependency I can't upgrade it to v0.5.0. So this version still depends on sharkdown and hence also the old version of minimist.

Update 2: Because I can't safely get to @mapbox/geojson-rewind version 0.5.0, I'm just going to merge this as-is.

@watson watson merged commit ad6d926 into elastic:6.8 Jun 16, 2021
@watson watson deleted the bump-minimist branch June 16, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v6.8.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants