-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Move empty string handling into field formatter #102877
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested both Lens and Visualize. It also has fixed the problem in vislib (we didn't have an open issue for that, but now it works as Lens, it renders (empty) for empty strings).
Tbh, I prefer it that way. As soon as we visualize it with (empty), it makes perfect sense to me to also apply this change to the Inspector and the csv export.
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AppServices converter change LGTM.
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
# Conflicts: # x-pack/test/functional/apps/discover/__snapshots__/reporting.snap
Fixes #93969
Fixes #68060
This PR removes the local handling of empty strings as
(empty)
and moves this logic into the string field formatter which can handle it in a single place.This has two effects:
The most debatable side effect IMHO is that this is also reflected in formatted csv exports. I still don't think it's worth a flag of some kind, but LMK what you think.