Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Product 404 polish pass #103198

Merged
merged 10 commits into from
Jun 24, 2021
Merged

[Enterprise Search] Product 404 polish pass #103198

merged 10 commits into from
Jun 24, 2021

Commits on Jun 24, 2021

  1. Refactor NotFound component 

    - shared NotFound becomes NotFoundPrompt - returns only an EuiEmptyPrompt, and individual products/plugins are in charge of their own layout, rather than NotFound doing a bunch of arduous switch handling (also closer to how errorConnecting is a component set per-plugin)

- This is both due to the recent page template refactor and the fact that WS has extra complex logic of needing to switch between its kibana layout and personal dashboard layout

- logos are still hosted in shared/ since they need extra custom CSS to work correctly sizing wise and in dark mode. I renamed its folder from `assets`->`logos` for extra clarity
    @cee-chen
    cee-chen committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    a86818c View commit details
    Browse the repository at this point in the history

  2. [AS] Update current AS routers using NotFound 

    + update EngineRouter to use NotFound
    @cee-chen
    cee-chen committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    f4bedcb View commit details
    Browse the repository at this point in the history

  3. [WS] Update app router 

    - Handle errorConnecting at the topmost level, instead of in WorkplaceSearchConfigured (to simplify various logic/expectations & match App Search)

- Simplify isOrganization check to use `useRouteMatch` instead of a regex

- Use new NotFound component
- Add NotFound component for the personal dashboard router
    @cee-chen
    cee-chen committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    4089bb1 View commit details
    Browse the repository at this point in the history

  4. [WS] Improve Source 404 UX 

    - Add NotFound to SourceRouter + add breadcrumbs for organization views

- When an actual source ID 404s, fix blanket redirect to a dashboard aware redirect - personal dashboard 404s should send the user back to personal sources, not organization sources
+ add a flash message error (similar to how App Search behaves for engine 404s)
+ harden error status checks (gracefully allow for non-http errors to fall back flashAPIErrors
    @cee-chen
    cee-chen committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    90c7fc4 View commit details
    Browse the repository at this point in the history

  5. [WS] Improve Settings 404 UX 

    - This was the only remaining WS route I found that either did not have a 404 or a fallback to some overview page, so I tweaked the redirect order for a graceful redirect (vs a blank page)
    @cee-chen
    cee-chen committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    8f19efb View commit details
    Browse the repository at this point in the history

  6. Fix settings router test

    Constance authored Jun 24, 2021
    Configuration menu
    Copy the full SHA
    fdbdd74 View commit details
    Browse the repository at this point in the history

  7. Move away from custom product logos to OOTB Enterprise Search logo 

    Keeping it simple, etc. RIP in peace fancy logos
    @cee-chen
    cee-chen committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    ff5f2d9 View commit details
    Browse the repository at this point in the history

  8. [PR feedback] toContain over stringContaining

    @cee-chen
    cee-chen committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    36b753c View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into kibana-page-template-errors

    @kibanamachine
    kibanamachine authored Jun 24, 2021
    Configuration menu
    Copy the full SHA
    da7365c View commit details
    Browse the repository at this point in the history

  10. aaaaaaaaaaaahhhh

    Constance authored Jun 24, 2021
    Configuration menu
    Copy the full SHA
    ae8a3ed View commit details
    Browse the repository at this point in the history