Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Formula can be colored by value #103572

Merged
merged 4 commits into from
Jun 30, 2021
Merged

[Lens] Formula can be colored by value #103572

merged 4 commits into from
Jun 30, 2021

Conversation

wylieconlon
Copy link
Contributor

Fixes bug where the mathColumn was returning a null type when the first row was null, which is guaranteed when using differences in formulas.

Screen Shot 2021-06-28 at 5 47 30 PM

Checklist

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 28, 2021
@wylieconlon wylieconlon requested a review from a team as a code owner June 28, 2021 21:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jun 28, 2021
@flash1293
Copy link
Contributor

This error is great:

│       Error: expected '222,420' to sort of equal '222420'
│       + expected - actual
│ 
│       -222,420
│       +222420

It's working better than before and is applying the number formatter correctly now

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 210.1KB 210.2KB +129.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan
tsullivan approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed the code and ran the functional test locally

@flash1293 flash1293 mentioned this pull request Jun 30, 2021
Closed
14 tasks
@wylieconlon wylieconlon merged commit 39b6597 into elastic:master Jun 30, 2021
@wylieconlon wylieconlon deleted the lens/fix-color-by-value branch June 30, 2021 13:47
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 30, 2021
@kibanamachine
[Lens] Formula can be colored by value (elastic#103572)
4495fc6 
* [Lens] Formula can be colored by value

* Fix mapColumn test

* Fix tests
@kibanamachine kibanamachine mentioned this pull request Jun 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
✅ 7.x
❌ 7.15 The branch "7.15" is invalid or doesn't exist

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 103572

kibanamachine added a commit that referenced this pull request Jun 30, 2021
@kibanamachine
[Lens] Formula can be colored by value (#103572) (#103886)
eca77cd 
* [Lens] Formula can be colored by value

* Fix mapColumn test

* Fix tests

Co-authored-by: Wylie Conlon <[email protected]>
flash1293 pushed a commit to flash1293/kibana that referenced this pull request Jul 7, 2021
@flash1293
[Lens] Formula can be colored by value (elastic#103572)
1eb53ea 
* [Lens] Formula can be colored by value

* Fix mapColumn test

* Fix tests
@flash1293 flash1293 mentioned this pull request Jul 7, 2021
Merged
flash1293 added a commit that referenced this pull request Jul 7, 2021
@flash1293
[Lens] Formula can be colored by value (#103572) (#104640)
794a2b0 
* [Lens] Formula can be colored by value

* Fix mapColumn test

* Fix tests

Co-authored-by: Wylie Conlon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wylieconlon @elasticmachine @flash1293 @kibanamachine @tsullivan