Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] i18n tinymath help text #104205

Merged
merged 3 commits into from
Jul 6, 2021
Merged

[Lens] i18n tinymath help text #104205

merged 3 commits into from
Jul 6, 2021

Conversation

wylieconlon
Copy link
Contributor

This was pointed out by @Bamieh after the translation strings were sent for 7.14, but we'll need to update these for 7.15. The .markdown suffix is what we've agreed on to run the strings through a special process.

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 1, 2021
@wylieconlon wylieconlon requested review from Bamieh and a team July 1, 2021 20:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and still works, LGTM

Bamieh
Bamieh approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +1.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon wylieconlon merged commit df8f870 into elastic:master Jul 6, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 6, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 6, 2021
@kibanamachine
[Lens] i18n tinymath help text (elastic#104205)
df83b4c 
* [Lens] i18n tinymath help text

* Fix i18n ids for remaining strings

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@wylieconlon wylieconlon deleted the lens/i18n-tinymath branch July 6, 2021 13:54
kibanamachine added a commit that referenced this pull request Jul 6, 2021
@kibanamachine
[Lens] i18n tinymath help text (#104205) (#104452)
4389396 
* [Lens] i18n tinymath help text

* Fix i18n ids for remaining strings

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Wylie Conlon <[email protected]>
@flash1293 flash1293 mentioned this pull request Jul 8, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@Bamieh Bamieh Bamieh approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wylieconlon @elasticmachine @flash1293 @kibanamachine @Bamieh