Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove elasticsearch package imports from reporting #107126

Conversation

mshustov
Copy link
Contributor

Summary

Use typings imported from @elastic/elasticsearch package

@mshustov mshustov added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Jul 29, 2021
@@ -77,24 +74,6 @@ export function registerJobGenerationRoutes(reporting: ReportingCore, logger: Lo
});
}

if (err instanceof esErrors['401']) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporting doesn't have access to the legacy client errors, so this code is dead and I removed it. If you considered this logic is necessary, please update it in a follow-up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this code was not doing anything special but adding a custom message on top of an error code. These error codes seem appropriate: I'm not seeing unexpected transformation of these codes to a custom message. I don't think this logic was necessary.

@mshustov mshustov added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 29, 2021
@mshustov mshustov enabled auto-merge (squash) July 29, 2021 08:52
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov requested review from tsullivan and a team July 29, 2021 12:04
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshustov mshustov merged commit 5294f1c into elastic:master Jul 30, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 30, 2021
* remove elasticsearch package imports from reporting

* remove dead code
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

@mshustov mshustov deleted the reporting-remove-elasticsearch-package-imports branch July 30, 2021 17:43
kibanamachine added a commit that referenced this pull request Jul 31, 2021
* remove elasticsearch package imports from reporting

* remove dead code

Co-authored-by: Mikhail Shustov <[email protected]>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
* remove elasticsearch package imports from reporting

* remove dead code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants