Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EuiCodeEditor from advanced settings #107394

Closed
wants to merge 2 commits into from

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Aug 2, 2021

Summary

Part of #106931

Switches from EuiCodeEditor to use the internal CodeEditor (using Monaco) for advanced settings.

TODO:

Checklist

Delete any items that are not applicable to this PR.

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 2, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
advancedSettings 57 49 -8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 912.6KB 68.0KB -844.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 9.0KB 9.1KB +69.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes
Copy link
Contributor Author

timroes commented Sep 7, 2021

Closing for now as stalled. Since we imported the EuiCodeEditor from Kibana for now, we're focusing on more important tasks first.

@timroes timroes closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants