Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Lens] Synchronize cursor position for X-axis across all Lens visualizations in a dashboard (#106845) #107691

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Aug 4, 2021

Backports the following commits to 7.x:

…zations in a dashboard (elastic#106845)

* [Lens] Synchronize cursor position for X-axis across all Lens visualizations in a dashboard

Closes: elastic#77530

* add mocks for active_cursor service

* fix jest tests

* fix jest tests

* apply PR comments

* fix cursor style

* update heatmap, jest

* add tests

* fix wrong import

* replace cursor for timelion

* update tsvb_dashboard baseline

* fix CI

* update baseline

* Update active_cursor_utils.ts

* add debounce

* remove cursor from heatmap and pie

* add tests for debounce

* return theme order back

Co-authored-by: Kibana Machine <[email protected]>
@alexwizp alexwizp enabled auto-merge (squash) August 4, 2021 19:21
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
charts 68 72 +4
visTypeTimelion 66 65 -1
visTypeTimeseries 538 537 -1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.6MB 1.6MB +402.0B
visTypeTimelion 89.3KB 89.1KB -198.0B
visTypeTimeseries 1004.1KB 1003.9KB -154.0B
visTypeXy 113.6KB 113.9KB +314.0B
total +364.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 88.7KB 92.2KB +3.5KB
visTypeTimelion 24.6KB 25.1KB +446.0B
visTypeTimeseries 24.6KB 24.5KB -20.0B
visTypeXy 62.1KB 62.5KB +359.0B
total +4.2KB
Unknown metric groups

API count

id before after diff
charts 190 194 +4

API count missing comments

id before after diff
charts 159 163 +4

Non-exported public API item count

id before after diff
charts 1 3 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 602e26b into elastic:7.x Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants