[APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds #107850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
sorenlouv
force-pushed
the
convert-tpm-to-tps-for-charts-only
branch
from
ea1a98f
to
43fe126
Compare
sorenlouv
added
release_note:fix
v7.15.0
auto-backport
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
commented
Aug 7, 2021
.../server/lib/services/get_service_error_groups/get_service_error_group_detailed_statistics.ts
Show resolved
Hide resolved
|
jenkins run the e2e |
sorenlouv
changed the title
sorenlouv
changed the title
sorenlouv
changed the title
| }) | ||
| : i18n.translate('xpack.apm.serviceOverview.tpsHelp', { | ||
| defaultMessage: | ||
| 'Throughput is measured in tps (transactions per second)', |
There was a problem hiding this comment.
Maybe you could inform the user when we break from tpm to tps?!
There was a problem hiding this comment.
Yes, I thought about it but didn't want it to be too confusing. So rather than explaining what both tpm and tps is, it just explains the current state.
WDYT @formgeist ?
There was a problem hiding this comment.
Not sure we need to clarify when we switch. I would suggest only to clearly show a different measurement when we switch to seconds. The default measure is minutes, which we can still show in a tooltip next to the title. But we'll change the title and tooltip when we switch, like so;
There was a problem hiding this comment.
@formgeist I added the (per second) label
cauemarcondes
requested changes
Aug 9, 2021
.../server/lib/services/get_service_error_groups/get_service_error_group_detailed_statistics.ts
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/services/get_service_instances/detailed_statistics.ts
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/transaction_groups/get_error_rate.ts
Outdated
Show resolved
Hide resolved
|
@sqren It looks like the chart legends are not correct.
|
# Conflicts: # x-pack/plugins/apm/server/routes/services.ts
sorenlouv
force-pushed
the
convert-tpm-to-tps-for-charts-only
branch
from
6275679
to
8f4f227
Compare
|
@cauemarcondes All comments addressed. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Found a tiny copy bug and reported it here #108171 |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 11, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (101 commits) [ML] APM Latency Correlations: Field/value candidates prioritization (elastic#107370) [Reporting] Add lenience to a test on the order of asserted logs (elastic#108135) [Lens] fix do not submit invalid query in filtered metric (elastic#107542) skip flaky test (elastic#108043) fix newly introduced type error (elastic#107593) [Reporting] server side code clean up (elastic#106940) [build_ts_refs] improve caches, allow building a subset of projects (elastic#107981) [APM] Add new ftr_e2e to kibana CI and remove current e2e tests. (elastic#107593) add manage rules link to alerts dropdown (elastic#107950) [ML] Enable Index data visualizer document count chart to update time range query (elastic#106438) [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (elastic#107230) [Actions UI] Fixed Jira Api token label. (elastic#107776) [Alerting UI] Fixed display permissions for edit/delete buttons when user has read only access. (elastic#107996) [Maps] fix code owners (elastic#108106) Update EMS landing page url (elastic#108102) Do not render page header for loading domains (elastic#108078) Update dependency @elastic/charts to v33.2.2 (elastic#107939) [APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds (elastic#107850) [Fleet] Fix all category count (elastic#108089) [Security Solution][Bug] - Disable alert table RBAC until fields sorted (elastic#108034) ... # Conflicts: # x-pack/plugins/reporting/server/export_types/common/generate_png.ts # x-pack/plugins/reporting/server/lib/screenshots/index.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.ts
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Aug 11, 2021
…0 seconds (elastic#107850) Co-authored-by: Kibana Machine <[email protected]>
sorenlouv
added a commit
that referenced
this pull request
Aug 11, 2021
…0 seconds (#107850) (#108217) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35938
This only converts the units from tpm to tps for the throughput chart, when the bucketsize is less than 1 minute. Throughput metrics (stats) in tables are left untouched.
Before
After