[Maps] fix choropleth map with applyGlobalQuery set to false still creates filter for source. #108999
Conversation
…eates filter for source.
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
| @@ -75,7 +75,6 @@ export interface IVectorSource extends ISource { | |||
| defaultFields: Record<string, Record<string, string>> | |||
| ): Promise<void>; | |||
| deleteFeature(featureId: string): Promise<void>; | |||
| isFilterByMapBounds(): boolean; | |||
There was a problem hiding this comment.
not relevant to this fix, but this method exists ISource and does not need to be duplicated in VectorSource
There was a problem hiding this comment.
Really improves the default-behavior.
discussed offline; since this is now more "automagic", it might not be clear to an end-user why a different filter is created than what the name in the tooltip would suggest.
^ perhaps we can make the iso2-row standout as a special "join-row" (e.g. using chain icon), with some helptext in a tooltip explaining its purpose.
|
@elasticmachine merge upstream |
Added a "link" icon with tooltip to show that a field is a join field.
@gchaps Maybe you can review at the copy? Not sure if its too long and if the first sentence is even needed. |
|
I agree that the tooltip is a little long. Here's the text we brainstormed: Shared key 'ISO 3166-1 alpha' is joined with 'geo.src'. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…eates filter for source. (elastic#108999) * [Maps] fix choropleth map with applyGlobalQuery set to false still creates filter for source. * cleanup functional test * eslint * fix functional test * add inidication in tooltip when field is join key * copy updates * update jest test * eslint Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…eates filter for source. (#108999) (#109915) * [Maps] fix choropleth map with applyGlobalQuery set to false still creates filter for source. * cleanup functional test * eslint * fix functional test * add inidication in tooltip when field is join key * copy updates * update jest test * eslint Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Nathan Reese <[email protected]>
Fixes #64861.
When creating a phrase filter for a layer with joins, a filter should not be created for the left source when the left source is a Documents source and applyGlobalQuery is set to false. Using map.regionmap.* has been a work around for this issue. This workaround will being going away in 8.0 with removal of map.regionmap.* kibana.yml settings.