[Canvas] Add default CSS if workpad CSS is missing #109961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poffdeluxe
added
loe:small
poffdeluxe
added
Feature:Canvas
review
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
poffdeluxe
force-pushed
the
bug/canvas-blank-css
branch
from
bf9738c
to
c209c84
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
poffdeluxe
added a commit
to poffdeluxe/kibana
that referenced
this pull request
Nov 3, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 3, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 3, 2021
poffdeluxe
added a commit
that referenced
this pull request
Nov 3, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 3, 2021
Co-authored-by: Poff Poffenberger <[email protected]>
poffdeluxe
added a commit
that referenced
this pull request
Nov 3, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 3, 2021
Co-authored-by: Poff Poffenberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to: #94075
The style-it dependency that Canvas uses for placing custom CSS in a workpad will not render the parent element passed in to it if the CSS is empty. This fix supplies the default workpad CSS if for some reason there is no CSS in the workpad itself.
This is a bit of a bandaid until we remove style-it from Canvas (See: #88715)