[Cases] Fix export flaky test #112456
Merged
[Cases] Fix export flaky test #112456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
v8.0.0
release_note:skip
This was
linked to
issues
Sep 16, 2021
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
cnasikas
approved these changes
Sep 17, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2021
* Refactoring flaky test * Forcing error in ci * Removing fast fail * remove .only Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2021
* Refactoring flaky test * Forcing error in ci * Removing fast fail * remove .only Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #112207, #112353
This PR fixes some flaky tests for exporting cases. The issue was likely that the export route is returning the objects in different order that we were originally expecting. The solution is to search for the types of objects and then perform the checks on them.
I ran it through the flaky test runner here and it passed 👍
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1903/