Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes misc unused so/server/es config deprecations #113173

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Sep 27, 2021

Related to #103915

During the 7 series, we added deprecations for configs that were unused to warn folks that setting these would have no effect.
To prepare for the first release of the next major version, we shouldn't be supporting any carried over deprecations and can remove the unused settings.

This PR removes the following 4 unused configurations:

To reviewers
I couldn't find any other reference to these settings in the docs or tests, hence the tiny PR. If I've missed something, please shout!

Release note

Removes support for savedObjects.indexCheckTimeout, server.xsrf.token, elasticsearch.preserveHost and elasticsearch.startupTimeout configuration settings.
Configuring any of these settings will prevent Kibana from starting up.

@TinaHeiligers TinaHeiligers added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Sep 27, 2021
@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Sep 27, 2021

@lukeelmers is removing already unused settings from deprecations a breaking change? If so, do we want to add individual breaking changes release notes or bundle them all up on one? I've added a release-note skip as a placeholder for now.

@lukeelmers
Copy link
Member

is removing already unused settings from deprecations a breaking change?

It is, because users who have been ignoring the deprecation warnings will now no longer be able to start Kibana without removing the unused setting.

do we want to add individual breaking changes release notes or bundle them all up on one?

No strong preference, but since there are several of them I would probably lean toward consolidating into one list?

@TinaHeiligers TinaHeiligers added release_note:breaking and removed release_note:skip Skip the PR/issue when compiling release notes labels Sep 27, 2021
@TinaHeiligers
Copy link
Contributor Author

users who have been ignoring the deprecation warnings will now no longer be able to start Kibana without removing the unused setting

It didn't even cross my mind that folks would ignore a deprecation warning 😆 .

@TinaHeiligers TinaHeiligers marked this pull request as ready for review September 27, 2021 22:32
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner September 27, 2021 22:32
@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@mshustov mshustov added the backport:skip This commit does not require backporting label Sep 28, 2021
@mshustov mshustov added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Sep 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers TinaHeiligers merged commit c647929 into elastic:master Sep 28, 2021
@TinaHeiligers TinaHeiligers deleted the config-breaking/remove-deprecated-configs-misc branch September 28, 2021 15:01
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:breaking Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants