Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes support for unused optimize.* settings from core deprecations #113296

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Sep 28, 2021

Related to #103915

The legacy optimizer was removed in #73154 and the configuration settings for that were deprecated as unused.
As of 8.0, Kibana won't support the legacy optimize.* settings anymore and will fail to start if any of those are configured.

This PR removes support for the following configurations:

  • optimize.lazy,
  • optimize.lazyPort,
  • optimize.lazyHost,
  • optimize.lazyPrebuild,
  • optimize.lazyProxyTimeout,
  • optimize.enabled,
  • optimize.bundleFilter,
  • optimize.bundleDir,
  • optimize.viewCaching,
  • optimize.watch,
  • optimize.watchPort,
  • optimize.watchHost,
  • optimize.watchPrebuild,
  • optimize.watchProxyTimeout,
  • optimize.useBundleCache,
  • optimize.sourceMaps,
  • optimize.workers,
  • optimize.profile,
  • optimize.validateSyntaxOfNodeModules

Screen shots (docs)

In breaking changes in 8.0:
Screen Shot 2021-09-28 at 10 26 50

Release note

Legacy optimize.* settings are no longer supported. Configurations with any of the following legacy optimize.* settings will prevent Kibana from starting up. Going forward, to run the @kbn/optimizer separately in development, pass --no-optimizer to yarn start. See #73154 for more details.

@TinaHeiligers TinaHeiligers added release_note:breaking Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 backport:skip This commit does not require backporting labels Sep 28, 2021
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added two (optional) wording suggestions

docs/migration/migrate_8_0.asciidoc Outdated Show resolved Hide resolved
docs/migration/migrate_8_0.asciidoc Outdated Show resolved Hide resolved
@TinaHeiligers TinaHeiligers marked this pull request as ready for review September 28, 2021 18:05
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner September 28, 2021 18:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

fyi @elastic/kibana-operations

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit 8d8b400 into elastic:master Sep 28, 2021
@TinaHeiligers TinaHeiligers deleted the config-breaking/remove-deprecated-configs-optimizer branch September 28, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:breaking Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants