Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Enable ML Embeddables in Canvas #113309

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Sep 28, 2021

Summary

Blocked by #113827.

This adds Canvas to the list of allowed appIds that can render the job selection flyout as part of the workflow for creating an ML embeddable (ie. anomaly swimlane and anomaly chart).

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@cqliu1 cqliu1 changed the base branch from master to canvas/by-value-embeddables October 4, 2021 00:20
@cqliu1 cqliu1 force-pushed the canvas/by-value-embeddables branch from e669879 to ddb8632 Compare October 5, 2021 18:54
@cqliu1 cqliu1 force-pushed the canvas/by-value-embeddables branch from ddb8632 to b706dfd Compare October 5, 2021 20:57
@cqliu1 cqliu1 force-pushed the canvas/by-value-embeddables branch from b706dfd to 2030a15 Compare October 12, 2021 18:55
@cqliu1 cqliu1 force-pushed the canvas/ml-embeddables branch 3 times, most recently from 891a62a to ac9aa93 Compare October 13, 2021 18:33
@cqliu1 cqliu1 force-pushed the canvas/ml-embeddables branch 4 times, most recently from f355a86 to c1fd1d7 Compare October 14, 2021 17:51
@cqliu1 cqliu1 added Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WIP Work in progress labels Oct 14, 2021
@cqliu1 cqliu1 force-pushed the canvas/by-value-embeddables branch from 2030a15 to afea023 Compare October 15, 2021 17:33
@cqliu1 cqliu1 force-pushed the canvas/by-value-embeddables branch from afea023 to 6b2bc48 Compare October 15, 2021 19:47
@cqliu1 cqliu1 force-pushed the canvas/ml-embeddables branch 2 times, most recently from fc9e966 to 90d9273 Compare October 15, 2021 19:53
@cqliu1 cqliu1 force-pushed the canvas/by-value-embeddables branch 2 times, most recently from 7557017 to f8dbcaf Compare October 19, 2021 16:00
@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 force-pushed the canvas/by-value-embeddables branch 7 times, most recently from 46edbbe to dc6a861 Compare October 26, 2021 16:23
Fixed conditional

Restore ml embeddable options
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 26, 2021

⏳ Build in-progress, with failures

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [dc6a861]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 deleted the branch elastic:canvas/by-value-embeddables October 27, 2021 18:58
@cqliu1 cqliu1 closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants