-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes unused and renamed deprecated core settings and deprecated settings from core plugins #113653
Merged
TinaHeiligers
merged 11 commits into
elastic:master
from
TinaHeiligers:config-breaking/remove-deprecations
Oct 5, 2021
Merged
Removes unused and renamed deprecated core settings and deprecated settings from core plugins #113653
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d570711
removes unused newsfeed.defaultLanguage config setting
TinaHeiligers 2aadf93
removes xpack.banners.placement:top config value change deprecation n…
TinaHeiligers ac97a83
Removes support for xpack.xpack_main.xpack_api_polling_frequency
TinaHeiligers 71f40d3
Removes breaking changes entry for xpack.xpack_main.xpack_api_polling…
TinaHeiligers a4234b9
Removes support for deprecated kibana.disableWelcomeScreen
TinaHeiligers d762120
Removes support for renamed deprecated usage counters
TinaHeiligers 8017cef
Removes deprecation notice and support for cpu.cgroup.path.override a…
TinaHeiligers 9fd64e2
removes server.xsrf.whitelist renaming deprecation, updates test conf…
TinaHeiligers 7ac15e8
Removes deprecation notice for kibanaPathConf
TinaHeiligers 105b587
Changes cors deprecation to warning level, modifies test_utils to ver…
TinaHeiligers 290b48a
Merge branch 'master' into config-breaking/remove-deprecations
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,18 +16,22 @@ function collectDeprecations( | |
) { | ||
const deprecations = provider(configDeprecationFactory); | ||
const deprecationMessages: string[] = []; | ||
const deprecationLevels: string[] = []; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needed to test changing the |
||
const { config: migrated } = applyDeprecations( | ||
settings, | ||
deprecations.map((deprecation) => ({ | ||
deprecation, | ||
path, | ||
})), | ||
() => | ||
({ message }) => | ||
deprecationMessages.push(message) | ||
({ message, level }) => { | ||
deprecationMessages.push(message); | ||
deprecationLevels.push(level ?? ''); | ||
} | ||
); | ||
return { | ||
messages: deprecationMessages, | ||
levels: deprecationLevels, | ||
migrated, | ||
}; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
* 2.0. | ||
*/ | ||
|
||
import { get } from 'lodash'; | ||
// import { get } from 'lodash'; | ||
import { schema, TypeOf } from '@kbn/config-schema'; | ||
import { PluginConfigDescriptor } from 'kibana/server'; | ||
import { isHexColor } from './utils'; | ||
|
@@ -39,23 +39,4 @@ export type BannersConfigType = TypeOf<typeof configSchema>; | |
export const config: PluginConfigDescriptor<BannersConfigType> = { | ||
schema: configSchema, | ||
exposeToBrowser: {}, | ||
deprecations: () => [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The unit tests only tested |
||
(rootConfig, fromPath, addDeprecation) => { | ||
const pluginConfig = get(rootConfig, fromPath); | ||
if (pluginConfig?.placement === 'header') { | ||
addDeprecation({ | ||
message: 'The `header` value for xpack.banners.placement has been replaced by `top`', | ||
correctiveActions: { | ||
manualSteps: [ | ||
`Remove "xpack.banners.placement: header" from your kibana configs.`, | ||
`Add "xpack.banners.placement: to" to your kibana configs instead.`, | ||
], | ||
}, | ||
}); | ||
return { | ||
set: [{ path: `${fromPath}.placement`, value: 'top' }], | ||
}; | ||
} | ||
}, | ||
], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only added breaking changes for the settings that are documented.