Prevent Spaces from being disabled #115283

jportner · 2021-10-15T22:08:02Z

Resolves #82467.

* Change config * Remove related deprecations * Remove space-disabled elements from role management UI * Remove security_only functional tests

jportner

Author's notes for reviewers.

After this merges, we'll probably need to rebalance the CI jobs since we're getting rid of so many integration tests 🎉

jportner · 2021-10-15T22:13:46Z

x-pack/test/ui_capabilities/security_and_spaces/scenarios.ts

+ FooAllAtEverythingSpace,
+ FooAllAtNothingSpace,
+ FooReadAtEverythingSpace,
+ FooReadAtNothingSpace,


I added these scenarios because tests with the FooAll and FooRead users were present in the security_only test suite, but not in this security_and_spaces test suite.

🏅 Thanks for observing this and not just blindly deleting the other test suites. This was done intentionally back in the day in order to reduce unnecessary duplication between the test suites.

jportner · 2021-10-15T22:14:20Z

x-pack/test/ui_capabilities/security_and_spaces/scenarios.ts

-export const UserAtSpaceScenarios: [
- NoKibanaPrivilegesAtEverythingSpace,
- NoKibanaPrivilegesAtNothingSpace,
- SuperuserAtEverythingSpace,
- SuperuserAtNothingSpace,
- LegacyAllAtEverythingSpace,
- LegacyAllAtNothingSpace,
- DualPrivilegesAllAtEverythingSpace,
- DualPrivilegesAllAtNothingSpace,
- DualPrivilegesReadAtEverythingSpace,
- DualPrivilegesReadAtNothingSpace,
- GlobalAllAtEverythingSpace,
- GlobalAllAtNothingSpace,
- GlobalReadAtEverythingSpace,
- GlobalReadAtNothingSpace,
- EverythingSpaceAllAtEverythingSpace,
- EverythingSpaceAllAtNothingSpace,
- EverythingSpaceReadAtEverythingSpace,
- EverythingSpaceReadAtNothingSpace,
- NothingSpaceAllAtEverythingSpace,
- NothingSpaceAllAtNothingSpace,
- NothingSpaceReadAtEverythingSpace,
- NothingSpaceReadAtNothingSpace
-] = [
+export const UserAtSpaceScenarios = [


We don't need to specify the type like this when we use as const below 😉

kibanamachine · 2021-10-16T00:16:28Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`security`	459	456	-3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`security`	514.6KB	507.8KB	-6.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`security`	51.3KB	51.1KB	-202.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sabarasaba

stack management changes lgtm 🚀

jportner · 2021-10-18T12:02:11Z

@elasticmachine merge upstream

legrego

Looks great! Still testing locally, but I don't expect any complications there

legrego · 2021-10-18T11:27:46Z

docs/settings/spaces-settings.asciidoc

@@ -7,11 +7,6 @@

 By default, spaces is enabled in {kib}. To secure spaces, <<security-settings-kb,enable security>>.

-`xpack.spaces.enabled`::


I can't leave a comment on an unedited file, but we should update our docs to reflect the fact that we can't disable Spaces anymore. My preference is to keep the section, but change the wording to indicate that this is no longer possible as of 8.0. That said, I'll be ok if you'd rather remove this altogether.

We should also remove the language about all objects existing in the Default space after upgrade. That was only really relevant for folks upgrading from pre-6.5 to >= 6.5, and I sincerely hope that everyone has done that by now. It's just confusing/misleading for everyone else at this point.

kibana/docs/spaces/index.asciidoc

Lines 110 to 117 in 58f6d90

[float]

[[spaces-delete-started]]

=== Disable and version updates

Spaces are automatically enabled in {kib}. If you don't want use this feature,

you can disable it. For more information, refer to <<spaces-settings-kb,Spaces settings in {kib}>>.

When you upgrade {kib}, the default space contains all of your existing saved objects.

Great catch, I'll change this section to:

Starting in {kib} 8.0, the Spaces feature cannot be disabled.

legrego · 2021-10-18T11:30:32Z

...curity/public/management/roles/edit_role/privileges/kibana/simple_privilege_section/index.ts

- * 2.0.
- */
-
-export { SimplePrivilegeSection } from './simple_privilege_section';


You have no idea how happy I am to see this SimplePrivilegeSection removed ❤️

legrego · 2021-10-18T11:42:32Z

x-pack/test/ui_capabilities/security_and_spaces/scenarios.ts

+ FooAllAtEverythingSpace,
+ FooAllAtNothingSpace,
+ FooReadAtEverythingSpace,
+ FooReadAtNothingSpace,


🏅 Thanks for observing this and not just blindly deleting the other test suites. This was done intentionally back in the day in order to reduce unnecessary duplication between the test suites.

jbudz

kibana-docker LGTM

docs/spaces/index.asciidoc

Co-authored-by: Larry Gregory <[email protected]>

legrego

LGTM!

I think as a followup item (post FF) we should make the spaces plugin required within the security plugin, and remove the small amount of dead code we have on the server to account for Spaces being disabled.

cnasikas

Cases changes LGTM

kibanamachine · 2021-10-18T15:17:08Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`security`	459	456	-3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`security`	514.6KB	507.8KB	-6.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`security`	51.3KB	51.1KB	-202.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Prevent Spaces from being disabled

f118f83

* Change config * Remove related deprecations * Remove space-disabled elements from role management UI * Remove security_only functional tests

jportner added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 15, 2021

jportner mentioned this pull request Oct 15, 2021

[Meta] Platform Security team - 8.0 upgrade work #111160

Closed

jportner commented Oct 15, 2021

View reviewed changes

jportner marked this pull request as ready for review October 16, 2021 00:17

jportner requested review from a team as code owners October 16, 2021 00:17

jportner requested a review from legrego October 16, 2021 00:18

sabarasaba approved these changes Oct 18, 2021

View reviewed changes

Merge branch 'master' into issue-82467-prevent-disabling-spaces

054cd36

legrego reviewed Oct 18, 2021

View reviewed changes

jbudz approved these changes Oct 18, 2021

View reviewed changes

Update docs

ec4f969

jportner added the buildkite-ci label Oct 18, 2021

legrego reviewed Oct 18, 2021

View reviewed changes

docs/spaces/index.asciidoc Outdated Show resolved Hide resolved

Update docs/spaces/index.asciidoc

374dba1

Co-authored-by: Larry Gregory <[email protected]>

legrego approved these changes Oct 18, 2021

View reviewed changes

cnasikas approved these changes Oct 18, 2021

View reviewed changes

jportner enabled auto-merge (squash) October 18, 2021 13:37

jportner merged commit 0f1c7cc into elastic:master Oct 18, 2021

jportner deleted the issue-82467-prevent-disabling-spaces branch October 18, 2021 15:20

jonathan-buttner mentioned this pull request Jul 27, 2022

[ResponseOps][Cases] Refactoring client args and authentication #137345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent Spaces from being disabled #115283

Prevent Spaces from being disabled #115283

jportner commented Oct 15, 2021 •

edited

Loading

jportner left a comment

jportner Oct 15, 2021

legrego Oct 18, 2021

jportner Oct 15, 2021

kibanamachine commented Oct 16, 2021

sabarasaba left a comment

jportner commented Oct 18, 2021

legrego left a comment

legrego Oct 18, 2021

jportner Oct 18, 2021 •

edited

Loading

legrego Oct 18, 2021

legrego Oct 18, 2021

jbudz left a comment

legrego left a comment

cnasikas left a comment

kibanamachine commented Oct 18, 2021

		@@ -7,11 +7,6 @@

		By default, spaces is enabled in {kib}. To secure spaces, <<security-settings-kb,enable security>>.

		`xpack.spaces.enabled`::

	[float]
	[[spaces-delete-started]]
	=== Disable and version updates

	Spaces are automatically enabled in {kib}. If you don't want use this feature,
	you can disable it. For more information, refer to <<spaces-settings-kb,Spaces settings in {kib}>>.

	When you upgrade {kib}, the default space contains all of your existing saved objects.

Prevent Spaces from being disabled #115283

Prevent Spaces from being disabled #115283

Conversation

jportner commented Oct 15, 2021 • edited Loading

jportner left a comment

Choose a reason for hiding this comment

jportner Oct 15, 2021

Choose a reason for hiding this comment

legrego Oct 18, 2021

Choose a reason for hiding this comment

jportner Oct 15, 2021

Choose a reason for hiding this comment

kibanamachine commented Oct 16, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

sabarasaba left a comment

Choose a reason for hiding this comment

jportner commented Oct 18, 2021

legrego left a comment

Choose a reason for hiding this comment

legrego Oct 18, 2021

Choose a reason for hiding this comment

jportner Oct 18, 2021 • edited Loading

Choose a reason for hiding this comment

legrego Oct 18, 2021

Choose a reason for hiding this comment

legrego Oct 18, 2021

Choose a reason for hiding this comment

jbudz left a comment

Choose a reason for hiding this comment

legrego left a comment

Choose a reason for hiding this comment

cnasikas left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 18, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

jportner commented Oct 15, 2021 •

edited

Loading

jportner Oct 18, 2021 •

edited

Loading