Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Enable writing rule execution events to Event Log by default #115394

Merged
merged 3 commits into from
Oct 19, 2021
Merged

[Security Solution][Detections] Enable writing rule execution events to Event Log by default #115394

merged 3 commits into from
Oct 19, 2021

Conversation

banderror
Copy link
Contributor

@banderror banderror commented Oct 18, 2021 •
edited
Loading

Tickets: #106469, #101013

Summary

  • Enables writing rule execution events to Event Log by default.
  • Updates Event Log's provider name used for rule execution logging to securitySolution.ruleExecution according to the RFC.

Config setting

The default config setting is now:

xpack.securitySolution.ruleExecutionLog.underlyingClient: 'eventLog'

The behaviour by default is now as follows:

  • the app is still using the legacy siem-detection-engine-rule-status saved objects
  • it writes the current status and last 5 failures to siem-detection-engine-rule-status
  • it reads data from siem-detection-engine-rule-status for both the Rule Management page and the Rule Details page
  • in addition to that it writes rule execution events to Event Log

If we notice any issues with Rule Monitoring in Security before the 7.16.0 release, we will revert the default value to savedObjects.

Checklist

@banderror banderror self-assigned this Oct 18, 2021
@banderror banderror added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Rule Monitoring Security Solution Detection Rule Monitoring release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team v7.16.0 v8.0.0 labels Oct 18, 2021
@banderror banderror requested a review from a team October 18, 2021 15:48
@banderror banderror marked this pull request as ready for review October 18, 2021 15:50
@banderror banderror requested a review from a team as a code owner October 18, 2021 15:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

spong
spong approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, tested locally, and verified Rule Execution Events were being written to the EventLog (and all existing functionality with Rule Monitoring/Details behaved as expected w/ the RuleStatus SO). So happy to finally enable this -- no going back now, thanks @banderror!! 🙂 🚀

@spong
Copy link
Member

spong commented Oct 18, 2021 •
edited
Loading

@elasticmachine merge upstream

edit: A little preemptive -- build is going to fail until #115440 is merged. Will re-merge once that makes it in.

@spong
Copy link
Member

spong commented Oct 18, 2021

@elasticmachine merge upstream

1 similar comment
@spong
Copy link
Member

spong commented Oct 19, 2021

@elasticmachine merge upstream

@banderror banderror force-pushed the enable-event-log-adapter-by-default branch from ef99110 to 77453f3 Compare October 19, 2021 11:10
@xcrzx xcrzx enabled auto-merge (squash) October 19, 2021 18:24
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @banderror

@xcrzx xcrzx merged commit 30ce299 into elastic:master Oct 19, 2021
@kibanamachine kibanamachine mentioned this pull request Oct 19, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 19, 2021
@banderror @xcrzx @kibanamachine
[Security Solution][Detections] Enable writing rule execution events …
badff8e 
…to Event Log by default (elastic#115394)

* Enable writing rule execution events to Event Log by default

* Update event log provider name according to the RFC

* Fix SavedObjectClient find method arguments

Co-authored-by: Dmitry Shevchenko <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 19, 2021
@kibanamachine @banderror @xcrzx
[Security Solution][Detections] Enable writing rule execution events …
fb9284a 
…to Event Log by default (#115394) (#115630)

* Enable writing rule execution events to Event Log by default

* Update event log provider name according to the RFC

* Fix SavedObjectClient find method arguments

Co-authored-by: Dmitry Shevchenko <[email protected]>

Co-authored-by: Georgii Gorbachev <[email protected]>
Co-authored-by: Dmitry Shevchenko <[email protected]>
@banderror banderror deleted the enable-event-log-adapter-by-default branch October 19, 2021 23:07
@banderror banderror mentioned this pull request Oct 20, 2021
Closed
@banderror banderror mentioned this pull request Nov 11, 2021
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@banderror banderror

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Rule Monitoring Security Solution Detection Rule Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@banderror @elasticmachine @spong @kibanamachine @xcrzx