[Maps] Remove proxyElasticMapsServiceInMaps #116184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
release_note:breaking
[Deprecated-Use Team:Presentation]Team:Geo
nreese
approved these changes
Oct 25, 2021
src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker
Outdated
Show resolved
Hide resolved
thomasneirynck
commented
Oct 25, 2021
| @@ -306,5 +290,3 @@ export const MAPS_NEW_VECTOR_LAYER_META_CREATED_BY = 'maps-new-vector-layer'; | |||
| export const MAX_DRAWING_SIZE_BYTES = 10485760; // 10MB | |||
|
|
|||
| export const emsWorldLayerId = 'world_countries'; | |||
| export const emsRegionLayerId = 'administrative_regions_lvl2'; | |||
| export const emsUsaZipLayerId = 'usa_zip_codes'; | |||
There was a problem hiding this comment.
this is unrelated. We removed hardcoded usage of these already when introducing the dynamic suggestEMSLayer API.
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
changed the title
jbudz
reviewed
Oct 25, 2021
src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker
Show resolved
Hide resolved
jbudz
approved these changes
Oct 25, 2021
nickpeihl
approved these changes
Oct 25, 2021
jbudz
approved these changes
Oct 25, 2021
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #82132
This removes the
map.proxyElasticMapsServiceInMapsyml setting. This flag allowed administrators to have Kibana act as a proxy to the Elastic Maps Service. The original idea behind this flag was to accommodate flexibility in how admins would setup their networks. E.g. in an airgapped environment, or in a DMZ, they may prefer to only configure outbound internet traffic to EMS for only the Kibana server, rather than all users.With the release of the on-prem Elastic Maps Server, this is much less of a requirement now.
For maintainers
This is a breaking change.