Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Renaming index patterns for job wizards #116250

Merged
merged 2 commits into from
Nov 1, 2021
Merged

[ML] Renaming index patterns for job wizards #116250

merged 2 commits into from
Nov 1, 2021

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Oct 26, 2021 •
edited by peteharverson
Loading

Follow on from #115191

115191 was created slightly too late for the big renaming task.

@jgowdyelastic jgowdyelastic added chore non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 26, 2021
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner October 26, 2021 08:36
@jgowdyelastic jgowdyelastic self-assigned this Oct 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic added v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Nov 1, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB -60.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit c9ccfad into elastic:main Nov 1, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 1, 2021
@jgowdyelastic @kibanamachine
[ML] Renaming index patterns for job wizards (elastic#116250)
bc71924 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Nov 1, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

@jgowdyelastic jgowdyelastic deleted the renaming-index-pattern-string-for-new-job-wizard branch November 1, 2021 13:11
kibanamachine added a commit that referenced this pull request Nov 1, 2021
@kibanamachine @jgowdyelastic
[ML] Renaming index patterns for job wizards (#116250) (#116935)
50f3b31 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgowdyelastic @elasticmachine @kibanamachine @peteharverson