[console] If using an https agent, set rejectUnauthorized in the agent #11700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
reviewed
May 10, 2017
| @@ -45,6 +45,7 @@ export class ProxyConfig { | |||
| }; | |||
|
|
|||
| if (values(sslAgentOpts).filter(Boolean).length) { | |||
| sslAgentOpts.rejectUnauthorized = this.verifySsl === undefined ? true : this.verifySsl; | |||
There was a problem hiding this comment.
Why === undefined and not == null?
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
May 11, 2017
elastic#11700) * [console] If using an https agent, set rejectUnauthorized in the agent * [console] Update tests to expect rejectUnauthorized in agent config * [console] Check for null and undefined when setting rejectUnauthorized
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
May 11, 2017
elastic#11700) * [console] If using an https agent, set rejectUnauthorized in the agent * [console] Update tests to expect rejectUnauthorized in agent config * [console] Check for null and undefined when setting rejectUnauthorized
This was referenced May 11, 2017
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
elastic#11700) * [console] If using an https agent, set rejectUnauthorized in the agent * [console] Update tests to expect rejectUnauthorized in agent config * [console] Check for null and undefined when setting rejectUnauthorized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently setting
will result in an error of
This probably broke sometime around the hapi or node upgrade, I'm still investigating. Instead of setting both rejectUnauthorized and an agent, this will set rejectUnauthorized on the agent.