[CI] Delete node_modules in between bootstrap attempts #117588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
Feature:CI
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
approved these changes
Nov 4, 2021
tylersmalley
reviewed
Nov 4, 2021
|
|
||
| # Most bootstrap failures will result in a problem inside node_modules that does not get fixed on the next bootstrap | ||
| # So, we should just delete node_modules in between attempts | ||
| rm -rf node_modules |
There was a problem hiding this comment.
We might want to consider yarn kbn clean as it also resets things like Bazel if there were an issue there. But deleting node_modules should accomplish what we're looking to resolve there without possible side-effects clean might have.
There was a problem hiding this comment.
Though, if we used clean we would have to re-extract the plugins. So, nevermind.
There was a problem hiding this comment.
Yeah, I really hope that there's never a time where Bazel starts to handle failures like yarn does
spalger
approved these changes
Nov 4, 2021
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 5, 2021
…ink-to-kibana-app * 'main' of github.com:elastic/kibana: (290 commits) [Connectors][ServiceNow] Remove SN flags (elastic#117511) [ML] Functional tests - stabilize and re-enable feature importance tests (elastic#117503) [RAC] Disable the actions button if the user has inadequate privileges (elastic#117488) [Visualize] [xyChart] filter labels by default (elastic#117288) Fix warning when setting description to undefined (elastic#117338) [build] Set monitoring.ui.container.elasticsearch.enabled for all containers (elastic#115087) fix types [Alerting] UX fixes for execution duration chart (elastic#117193) [CI] Delete node_modules in between bootstrap attempts (elastic#117588) Flaky test fixes (elastic#117028) [Security Solution] [Sourcerer] [Feature Branch] Update to use Kibana Data Views (elastic#114806) [ML] Hide anomaly entity filter button tooltips when clicked (elastic#117493) adjust the synthetics journey type (elastic#117316) Refines hasAnyData check for alerts (elastic#117499) [Fleet] Default to APM tutorial (elastic#117421) [Maps] update docs for index pattern -> data view rename (elastic#117400) [Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (elastic#116821) [Fleet] Fix agent logs not reading query from URL (elastic#117286) Fixing Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should successfully test valid es_query alert (elastic#114917) [Metrics UI] Add docs link to redundant groupBy detection (elastic#116822) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/shared_imports.ts # x-pack/plugins/reporting/server/routes/management/jobs.ts
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
brianseeders
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 11, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 11, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 11, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 11, 2021
…8279) Co-authored-by: Brian Seeders <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 11, 2021
…8280) Co-authored-by: Brian Seeders <[email protected]>
kibanamachine
removed
the
backport missing
kibanamachine
added a commit
that referenced
this pull request
Nov 11, 2021
…8281) Co-authored-by: Brian Seeders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bootstrap fails, it usually results in a problem inside
node_modulesthat is not corrected on the next bootstrap. This is likely because ofpostinstallscripts that don't run.See here for an example: https://buildkite.com/elastic/kibana-on-merge/builds/7291#37f2ecc1-4dc5-4789-bac2-99e7dac1d560
We have lots of random failures in CI because of this. Deleting
node_modulesbefore the retry should fix the problem.