Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Add a technical preview of connecting GitHub via GitHub apps #119764

Merged
merged 17 commits into from
Dec 6, 2021
Merged

[Workplace Search] Add a technical preview of connecting GitHub via GitHub apps #119764

merged 17 commits into from
Dec 6, 2021

Commits on Dec 2, 2021

  1. Add new routes 

    Render the new github_via_app component on the new routes (added in future commits).

Use isGithubEnterpriseServer prop as differentiator between github and github enterprise server
    Vadim Yakhin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    60cefa8 View commit details
    Browse the repository at this point in the history

  2. Add readUploadedFileAsText

    Vadim Yakhin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    a408a04 View commit details
    Browse the repository at this point in the history

  3. Add new view and logic for creating a GitHub content source via GitHu… 

    …b apps

Also rename github_app to github_via_app to match service_type on backend
    Vadim Yakhin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    5b839e9 View commit details
    Browse the repository at this point in the history

  4. Make editPath (path to connector settings) optional as it is 

    not available for GitHub apps which are configured on a source level
    Vadim Yakhin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    14397e4 View commit details
    Browse the repository at this point in the history

  5. Update source_settings and source_logic to include configuration for 

    new source types.

Add new "secret" field to ContentSourceFullData and mocks
    Vadim Yakhin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    5ef8ab8 View commit details
    Browse the repository at this point in the history

  6. Rename indexPermissions to index_permissions

    Vadim Yakhin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    0a558c4 View commit details
    Browse the repository at this point in the history

  7. Extract handlePrivateKeyUpload into a utility function

    Vadim Yakhin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    bb8e262 View commit details
    Browse the repository at this point in the history

  8. Extract github_via_app and github_enterprise_server_via_app to co… 

    …nstants
    Vadim Yakhin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    16b1813 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Add a basic validation: submit button is disabled if fields are empty

    Vadim Yakhin committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    9dcebdf View commit details
    Browse the repository at this point in the history

  2. Address PR feedback

    Vadim Yakhin committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    b16630d View commit details
    Browse the repository at this point in the history

  3. Do not rely on baseUrl field emptyness to define the service type 

    Rely on explicit parameter instead
    Vadim Yakhin committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    f4d1b71 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into github-app-connection

    @kibanamachine
    kibanamachine authored Dec 3, 2021
    Configuration menu
    Copy the full SHA
    1ce54d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Merge branch 'main' into github-app-connection

    @kibanamachine
    kibanamachine authored Dec 6, 2021
    Configuration menu
    Copy the full SHA
    6b68b77 View commit details
    Browse the repository at this point in the history

  2. Add icons to the new GitHub service types

    Vadim Yakhin committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    f2c218d View commit details
    Browse the repository at this point in the history

  3. Fix a bug where indexPermissionsValue was true even on basic license. 

    The solution copied from the add_source component.
    Vadim Yakhin committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    89e7b70 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'github-app-connection' of github.com:yakhinvadim/kibana… 

    … into github-app-connection
    Vadim Yakhin committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    83ca1ec View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into github-app-connection

    @kibanamachine
    kibanamachine authored Dec 6, 2021
    Configuration menu
    Copy the full SHA
    9057ed4 View commit details
    Browse the repository at this point in the history