Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] [Reporting] Decouple screenshotting plugin from the reporting (#120110) #120937

Merged
merged 1 commit into from
Dec 9, 2021
Merged

[8.0] [Reporting] Decouple screenshotting plugin from the reporting (#120110) #120937

merged 1 commit into from
Dec 9, 2021

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Dec 9, 2021

Backports the following commits to 8.0:

@dokmic
[Reporting] Decouple screenshotting plugin from the reporting (elasti…
ecd38f7 
…c#120110)

* Add screenshotting plugin
* Move screenshotting plugin configuration options
* Remove unused browser type configuration option
# Conflicts:
#	packages/kbn-optimizer/limits.yml
#	x-pack/plugins/reporting/server/export_types/common/generate_png.ts
#	x-pack/plugins/reporting/server/export_types/png/execute_job/index.ts
#	x-pack/plugins/reporting/server/export_types/png_v2/execute_job.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf/lib/tracker.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf_v2/lib/tracker.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable_handler.ts
@dokmic dokmic added the backport label Dec 9, 2021
@dokmic dokmic enabled auto-merge (squash) December 9, 2021 15:33
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
screenshotting - 8 +8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
reporting 163 164 +1
screenshotting - 11 +11
total +12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 56.3KB 56.3KB -41.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
reporting 15 16 +1
screenshotting - 5 +5
total +6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 42.0KB 41.8KB -224.0B
screenshotting - 2.0KB +2.0KB
total +1.8KB
Unknown metric groups

API count

id before after diff
reporting 166 167 +1
screenshotting - 25 +25
total +26

References to deprecated APIs

id before after diff
reporting 30 29 -1
screenshotting - 10 +10
total +9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dokmic dokmic merged commit 1ec14ab into elastic:8.0 Dec 9, 2021
@dokmic dokmic deleted the backport/8.0/pr-120110 branch December 9, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dokmic @kibana-ci