Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Upgrade Assistant] Update UX for 7.17 (#119798)" #121175

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Dec 14, 2021

For 7.16 we make some copy changes in UA and removed the reindex (step 2) functionality (#119798).

This PR reverts this work. (34dcc1e)

I've also put back the doc link fix (465eb23). This commit will have to be backported to main.

Note: This PR is currently targeting 7.16 to make the CI pass. Right before merging I will change it to the feature branch remove-deprecations.

@sebelga sebelga marked this pull request as ready for review December 14, 2021 15:02
@sebelga sebelga added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.17.0 v8.0.0 v8.1.0 labels Dec 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@sebelga sebelga changed the base branch from remove-deprecations to 7.16 December 14, 2021 17:30
@sebelga sebelga changed the base branch from 7.16 to remove-deprecations December 14, 2021 17:32
@sebelga sebelga changed the base branch from remove-deprecations to 7.16 December 14, 2021 17:34
@sebelga
Copy link
Contributor Author

sebelga commented Dec 14, 2021

@elasticmachine merge upstream

@sebelga sebelga added v7.17.0 v8.0.0 v8.1.0 release_note:skip Skip the PR/issue when compiling release notes labels Dec 14, 2021
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, though it seems that we lost the put back doc link fix commit after the merge upstream 🤔

@sebelga sebelga changed the base branch from 7.16 to remove-deprecations December 15, 2021 10:17
@sebelga
Copy link
Contributor Author

sebelga commented Dec 15, 2021

Thanks for the review @sabarasaba ! I was also a bit confused for not seeing the "put back doc link fix" commit until I realised that it was already in the target branch 😊 It makes sense, it's been fixed in 7.16

@sebelga sebelga merged commit 6bcbcb0 into elastic:remove-deprecations Dec 15, 2021
@sebelga sebelga deleted the ua/revert-716-changes branch December 15, 2021 10:43
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
upgradeAssistant 140 145 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 127.9KB 138.6KB +10.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 18.2KB 18.3KB +41.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants