Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified observability] Extract ObservabilityIndexPatterns from exploratory view #122132

Merged
merged 9 commits into from
Jan 18, 2022

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Dec 29, 2021

Summary

Part of #118242. Closes #120210

We want to use an embedded dashboard on the new overview page. Dashboards and Lens need to have a Kibana Data View to query the data.

The exploratory view has a mechanism to create data views on the fly and we want to reuse it. To do so we have done the following:

  • Moved the code to a shared location.
  • Refactor the deprecated indexPattern terminology, APIs and types.

@afgomez afgomez added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 Team:Unified observability labels Dec 29, 2021
@afgomez afgomez requested a review from a team as a code owner December 29, 2021 13:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Unified observability)

@afgomez afgomez requested a review from a team December 29, 2021 13:13
Copy link
Contributor

@estermv estermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@estermv
Copy link
Contributor

estermv commented Dec 30, 2021

After approving the PR, I thought a bit more about the new location... is it x-pack/plugins/observability/public/components/shared/ the best location for the ObservabilityDataViews, given that is not a component?

What do you think about moving it to the x-pack/plugins/observability/public/utils/ folder? Although I'm not a fan of the utils folders in general, it seems a more appropriate location.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 348 349 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 357.8KB 357.8KB -4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 79.3KB 79.3KB -44.0B
Unknown metric groups

References to deprecated APIs

id before after diff
observability 155 132 -23

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, agree with @estermv, x-pack/plugins/observability/public/utils/ seems to be the right place for these files.

Also checked out the branch and navigated around just to be sure everything still looks okay.

@afgomez afgomez merged commit 4d771c3 into elastic:main Jan 18, 2022
@afgomez afgomez deleted the 120210-obs-data-views branch January 18, 2022 15:40
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 18, 2022
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 122132

Questions ?

Please refer to the Backport tool documentation

ogupte pushed a commit to ogupte/kibana that referenced this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Unified observability v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Unified Observability] Centralized observability data views
6 participants