Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] fixed bug where fleet server instructions were incorrectly shown #125357

Merged
merged 1 commit into from
Feb 11, 2022
Merged

[Fleet] fixed bug where fleet server instructions were incorrectly shown #125357

merged 1 commit into from
Feb 11, 2022

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Feb 11, 2022 •
edited
Loading

Summary

Closes #125339

Bug introduced in #121628

Pre-requirements:

  1. ELK setup should be completed.
  2. Two different policies should be there:
  • One policy with Fleet Server integration.
  • One policy with only System integration.
  1. Fleet Server should be installed.

Steps to reproduce:

  1. Login to Kibana and navigate to Fleet>Agent Policies.
  2. Navigate to the policy with only System integration.
  3. Click Add Agent button.

Expected Result:
Respective policy should be selected on clicking Add Agent button from Agent Policies tab.

Fleet Server instructions should not be visible.

Root cause: Add Agent flyout is sometimes used without agentPolicies prop, and the logic to show Fleet Server instructions was relying on that.
As a fix, querying agentPolicies to make sure it is always set.

Checklist

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 labels Feb 11, 2022
@juliaElastic juliaElastic self-assigned this Feb 11, 2022
@juliaElastic juliaElastic requested a review from a team as a code owner February 11, 2022 10:50
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 660.1KB 660.2KB +128.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

kpollich
kpollich approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@juliaElastic juliaElastic merged commit 2d93bcb into elastic:main Feb 11, 2022
@juliaElastic juliaElastic deleted the fix-managed-instructions-fleet-server branch February 11, 2022 13:46
@kibanamachine kibanamachine mentioned this pull request Feb 11, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
@juliaElastic @kibanamachine
fixed bug where fleet server instructions were incorrectly shown (ela…
ad47e5b 
…stic#125357)

(cherry picked from commit 2d93bcb)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 11, 2022
@kibanamachine @juliaElastic
fixed bug where fleet server instructions were incorrectly shown (#12…
a5d761b 
…5357) (#125374)

(cherry picked from commit 2d93bcb)

Co-authored-by: Julia Bardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@juliaElastic juliaElastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet]: Fleet Server policy is selected on clicking Add Agent button from Agent Policies tab.
5 participants
@juliaElastic @elasticmachine @kibana-ci @kibanamachine @kpollich