Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] allow top metric for last value #127151

Merged
merged 28 commits into from
Mar 15, 2022
Merged

[Lens] allow top metric for last value #127151

merged 28 commits into from
Mar 15, 2022

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Mar 8, 2022 •
edited
Loading

Summary

Top metrics for last value

Resolves #102956

Screen Shot 2022-03-08 at 1 07 43 PM

Checklist

Delete any items that are not applicable to this PR.

@drewdaemon drewdaemon requested a review from a team as a code owner March 8, 2022 14:29
@drewdaemon drewdaemon changed the title 102956/allow top metric for last value [Lens] allow top metric for last value Mar 8, 2022
@drewdaemon drewdaemon marked this pull request as draft March 8, 2022 16:14
@drewdaemon drewdaemon added the ui-copy Review of UI copy with docs team is recommended label Mar 8, 2022
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@drewdaemon drewdaemon added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 8, 2022
@drewdaemon drewdaemon marked this pull request as ready for review March 8, 2022 19:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

flash1293
flash1293 reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good already, left some comments

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/terms/helpers.ts Outdated Show resolved Hide resolved
x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx Outdated Show resolved Hide resolved
x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx Outdated Show resolved Hide resolved
@drewdaemon drewdaemon requested a review from a team as a code owner March 10, 2022 01:49
@drewdaemon
Copy link
Contributor Author

Can use this exported dashboard to test the migration for both by-value and by-reference tables. Just add the e-commerce sample data first.

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM with one minor nit.

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx Show resolved Hide resolved
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +1.3KB
observability 398.6KB 398.6KB +19.0B
total +1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afgomez
afgomez reviewed Mar 15, 2022
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in observability LGTM

@flash1293 flash1293 added the backport:skip This commit does not require backporting label Mar 15, 2022
@drewdaemon drewdaemon merged commit a389226 into elastic:main Mar 15, 2022
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@drewdaemon @maksimkovalev
[Lens] allow top metric for last value (elastic#127151)
d30e618
@dej611 dej611 mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afgomez afgomez afgomez approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure ui-copy Review of UI copy with docs team is recommended v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Allow use of top metric for last value
6 participants
@drewdaemon @elasticmachine @flash1293 @kibana-ci @afgomez @kibanamachine