[Fleet] Redesign agent flyout #128381

criamico · 2022-03-23T14:55:55Z

Summary

Redesign of agent enrollment flyout: #125534

Try to enroll a new agent, the new UI should be like this:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

For maintainers

This was checked for breaking API changes and was labeled appropriately

joshdover · 2022-03-23T18:21:15Z

Submitted a PR to fix a few things here: criamico#1

criamico · 2022-03-24T17:42:00Z

@elasticmachine merge upstream

elasticmachine · 2022-03-24T17:42:10Z

Pinging @elastic/fleet (Team:Fleet)

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/instructions.tsx

juliaElastic · 2022-03-28T09:16:09Z

I noticed a broken feature in Add agent flyout, with Fleet Server instructions:

Create a Fleet Server policy
Bug: the created policy doesn't appear in the dropdown
Expected: the created Fleet Server policy should appear selected in agent policy dropdown

Also, when closing the flyout and navigating to other fleet tabs, I am getting this error:

Error: setSelectedPolicyId is not a function
    at useDefaultAgentPolicyEffect (http://localhost:5620/9007199254740991/bundles/plugin/fleet/kibana/fleet.chunk.0.js:39891:7)

juliaElastic · 2022-03-28T09:49:50Z

After enrolling a Fleet Server, and opening Add agent flyout, I see failing agent_status queries with this error:

Request URL: http://localhost:5620/api/fleet/agent_status/data
Request Method: GET
Status Code: 400 Bad Request
{"statusCode":400,"error":"Bad Request","message":"[request query.agentsIds]: expected at least one defined value but got [undefined]"}

criamico · 2022-03-28T09:51:50Z

@juliaElastic Thanks for testing it out! I'm looking at these issues.

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/agent_policy_select_create.tsx

criamico · 2022-03-28T10:35:48Z

@juliaElastic would you mind testing again those issues? I pushed a commit that should fix them.

criamico · 2022-03-28T10:55:36Z

@elasticmachine merge upstream

juliaElastic · 2022-03-28T11:17:55Z

@juliaElastic would you mind testing again those issues? I pushed a commit that should fix them.

Thanks, the fleet server enroll flow is fixed now.
I'm still seeing the error with the /agent_status/data call though.

juliaElastic · 2022-03-28T11:29:01Z

I tested the flow of enrolling agent to Fleet, and I see the UI updated to show that 1 agent has enrolled, and incoming data is confirmed. A few observations:

Confirm agent Enrollment step spinner keeps spinning even after agents has been enrolled. Is this expected?
The queries to check for agents/agent data keep going on in the background, even after closing the flyout. Is it expected or should it stop at some point?
The Confirm incoming data step is called Incoming data confirmed in the original issue, which is the final one? [Fleet] Agent Install Flyout Redesign #125534

juliaElastic · 2022-03-28T11:31:48Z

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/confirm_agent_enrollment.tsx

+ return (
+ <EuiText>
+ <FormattedMessage
+ id="xpack.fleet.enrollmentInstructions.troubleshootingText"


nit: the troubleshooting link could be extracted to a small component

x-pack/plugins/fleet/public/components/enrollment_instructions/manual/index.tsx

juliaElastic · 2022-03-28T11:49:42Z

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/confirm_agent_enrollment.tsx

+ * @param policyId
+ * @returns
+ */
+export const usePollingAgentCount = (policyId: string | undefined) => {


unit tests are missing, I think you can add them in another pr

criamico · 2022-03-28T12:51:27Z

I tested the flow of enrolling agent to Fleet, and I see the UI updated to show that 1 agent has enrolled, and incoming data is confirmed. A few observations:

Confirm agent Enrollment step spinner keeps spinning even after agents has been enrolled. Is this expected?

No, I still have to fix the state of the last two steps and the spinners. I'll check it.

The queries to check for agents/agent data keep going on in the background, even after closing the flyout. Is it expected or should it stop at some point?

No it should stop when the flyout closes. It is a bug.

The Confirm incoming data step is called Incoming data confirmed in the original issue, which is the final one? [Fleet] Agent Install Flyout Redesign #125534

I think it's supposed to be Confirm incoming data when loading and Incoming data confirmed when completed. I'll fix it along with the first point.

criamico · 2022-03-28T15:32:15Z

I pushed a commit where I addressed most of the problems, however I still need to fix the endpoints that keep getting called after closing the panel.

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/confirm_agent_enrollment.tsx

kpollich

It seems like after creating one agent, navigating back into the flyout incurs this "empty state" in the dropdown. I think this is similar to the issue @juliaElastic reported above.

juliaElastic · 2022-03-29T07:38:11Z

I noticed that when there is no Fleet Server enrolled initially, there is no way to see the Agent standalone instructions (which doesn't require Fleet Server).
Is this going to be solved by the second part? If so, should the 2 redesigns be included in the same release?

juliaElastic · 2022-03-29T07:42:34Z

It seems like after creating one agent, navigating back into the flyout incurs this "empty state" in the dropdown. I think this is similar to the issue @juliaElastic reported above.

@kpollich I couldn't reproduce this, do you have only one policy in the dropdown? It is expected to have an empty dropdown if you have at least 2 policies (e.g. fleet server policy, agent policy)

joshdover · 2022-04-11T10:58:53Z

I know, I also feel that it is confusing for the user since it could prevent the new agents from showing up. This functionality was added after a discussion with @joshdover.
Since it is quite easy to remove and it wasn't explicitly requested by a PM, I would remove it from this PR and later we might reevaluate it.

IMO it's more confusing to open the flyout and it already have this bright green success UI shown before the user has done anything?

Maybe we could enhance this in the future to have 2 separate indicators:

One big and obvious success confirmation similar to the one in this PR
A smaller indicator / link like "See X other agents enrolled in the last 15 minutes ->"

joshdover · 2022-04-11T11:00:02Z

BTW feel free to merge without my approval, I may not get to this today.

juliaElastic · 2022-04-11T11:18:31Z

IMO it's more confusing to open the flyout and it already have this bright green success UI shown before the user has done anything?

The confirmation will only show up if someone enrolled an agent to the selected agent policy in the last few minutes. That is unlikely to be done by someone else, isn't it?

juliaElastic · 2022-04-11T12:09:16Z

should the labels be updated to v8.3?

criamico · 2022-04-11T12:26:20Z

IMO it's more confusing to open the flyout and it already have this bright green success UI shown before the user has done anything?

Maybe we could enhance this in the future to have 2 separate indicators:

One big and obvious success confirmation similar to the one in this PR

A smaller indicator / link like "See X other agents enrolled in the last 15 minutes ->"

I think that this piece of functionality needs further investigation and possibly involvement of a PM. It is a good candidate for an enhancement ticket.

criamico · 2022-04-11T12:45:03Z

should the labels be updated to v8.3?

I think they want it merged for 8.2, but I'll check again.

kpollich · 2022-04-11T13:23:55Z

I'm having trouble getting past the "Confirm incoming data" step in Cloud.

I'm enrolling an agent in a basic Agent Policy that just includes the system integration, and I'm running the agent on my Macbook via docker, e.g.

docker run --rm --add-host elasticsearch.local:192.168.65.2 \
  -e FLEET_URL=https://6e3f3c836ed0d22d3db21117a0894f2f.fleet.us-west2.gcp.elastic-cloud.com:443\
  -e FLEET_ENROLL=true \
  -e FLEET_ENROLLMENT_TOKEN=MThjV0JJQUJFTENteXpEd0xBTDI6ZUZSRHpvVmlTUGVPWVFHWkhHTFZ3Zw== \
  docker.elastic.co/beats/elastic-agent:8.2.0-SNAPSHOT

My agent starts up as expected, and Fleet reports that it's enrolled, but the "Confirm incoming data" spinner never goes away. I let it sit for 15ish minutes with no change.

Here's what I think is the relevant polling request from my network tab:

/api/fleet/agents?page=1&perPage=20&showInactive=false&showUpgradeable=false

{
    "list": [
        {
            "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
            "access_api_key_id": "t3bDGIABELCmyzDwjYIP",
            "action_seq_no": [
                -1
            ],
            "active": true,
            "agent": {
                "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
                "version": "8.2.0"
            },
            "enrolled_at": "2022-04-11T13:15:10Z",
            "local_metadata": {
                "elastic": {
                    "agent": {
                        "build.original": "8.2.0-SNAPSHOT (build: 4b4938b6413972b890ea2f8d256b0e066deea109 at 2022-04-07 15:12:02 +0000 UTC)",
                        "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
                        "log_level": "info",
                        "snapshot": true,
                        "upgradeable": false,
                        "version": "8.2.0"
                    }
                },
                "host": {
                    "architecture": "x86_64",
                    "hostname": "6a2804ec7569",
                    "id": "",
                    "ip": [
                        "127.0.0.1/8",
                        "172.17.0.3/16"
                    ],
                    "mac": [
                        "02:42:ac:11:00:03"
                    ],
                    "name": "6a2804ec7569"
                },
                "os": {
                    "family": "debian",
                    "full": "Ubuntu focal(20.04.4 LTS (Focal Fossa))",
                    "kernel": "5.10.76-linuxkit",
                    "name": "Ubuntu",
                    "platform": "ubuntu",
                    "version": "20.04.4 LTS (Focal Fossa)"
                }
            },
            "policy_id": "b524cbd0-b671-11ec-9278-35137f95496f",
            "type": "PERMANENT",
            "updated_at": "2022-04-11T13:19:22Z",
            "last_checkin_status": "online",
            "last_checkin": "2022-04-11T13:19:18Z",
            "default_api_key": "uXbDGIABELCmyzDwloJS:0pk0edMnSTeiCyi6CxG14A",
            "default_api_key_id": "uXbDGIABELCmyzDwloJS",
            "policy_output_permissions_hash": "a98b2704d96f3a72c77ee2e499898bc091d3c710d56a7b75c9f7f7b7b0f14f7b",
            "policy_revision_idx": 1,
            "policy_coordinator_idx": 1,
            "policy_revision": 1,
            "status": "online",
            "packages": []
        },
        {
            "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
            "access_api_key_id": "J0tFAYABicK5TYBjdnJC",
            "action_seq_no": [
                -1
            ],
            "active": true,
            "agent": {
                "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
                "version": "8.3.0"
            },
            "enrolled_at": "2022-04-06T23:46:11Z",
            "local_metadata": {
                "elastic": {
                    "agent": {
                        "build.original": "8.3.0-SNAPSHOT (build: 12eb476712eed1b9b6b94f2b8c807df4ccac3b3b at 2022-04-06 16:14:16 +0000 UTC)",
                        "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
                        "log_level": "info",
                        "snapshot": true,
                        "upgradeable": false,
                        "version": "8.3.0"
                    }
                },
                "host": {
                    "architecture": "x86_64",
                    "hostname": "372f76872ca3",
                    "id": "",
                    "ip": [
                        "127.0.0.1/8",
                        "172.17.0.99/16"
                    ],
                    "mac": [
                        "02:42:ac:11:00:63"
                    ],
                    "name": "372f76872ca3"
                },
                "os": {
                    "family": "debian",
                    "full": "Ubuntu focal(20.04.4 LTS (Focal Fossa))",
                    "kernel": "4.15.0-1032-gcp",
                    "name": "Ubuntu",
                    "platform": "ubuntu",
                    "version": "20.04.4 LTS (Focal Fossa)"
                }
            },
            "policy_id": "policy-elastic-agent-on-cloud",
            "type": "PERMANENT",
            "default_api_key_id": "FrZMAYABELCmyzDwcwpl",
            "policy_output_permissions_hash": "1c50ec8787bd4cae8cb3e1325361e3ba281f88b698f9c401c0fd7846ff2aefb3",
            "default_api_key": "FrZMAYABELCmyzDwcwpl:_I6_CL8tR7aQ6QJEZcMxhg",
            "policy_revision_idx": 4,
            "policy_coordinator_idx": 1,
            "updated_at": "2022-04-11T13:19:42Z",
            "last_checkin_status": "online",
            "last_checkin": "2022-04-11T13:19:35Z",
            "policy_revision": 4,
            "status": "online",
            "packages": []
        }
    ],
    "items": [
        {
            "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
            "access_api_key_id": "t3bDGIABELCmyzDwjYIP",
            "action_seq_no": [
                -1
            ],
            "active": true,
            "agent": {
                "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
                "version": "8.2.0"
            },
            "enrolled_at": "2022-04-11T13:15:10Z",
            "local_metadata": {
                "elastic": {
                    "agent": {
                        "build.original": "8.2.0-SNAPSHOT (build: 4b4938b6413972b890ea2f8d256b0e066deea109 at 2022-04-07 15:12:02 +0000 UTC)",
                        "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
                        "log_level": "info",
                        "snapshot": true,
                        "upgradeable": false,
                        "version": "8.2.0"
                    }
                },
                "host": {
                    "architecture": "x86_64",
                    "hostname": "6a2804ec7569",
                    "id": "",
                    "ip": [
                        "127.0.0.1/8",
                        "172.17.0.3/16"
                    ],
                    "mac": [
                        "02:42:ac:11:00:03"
                    ],
                    "name": "6a2804ec7569"
                },
                "os": {
                    "family": "debian",
                    "full": "Ubuntu focal(20.04.4 LTS (Focal Fossa))",
                    "kernel": "5.10.76-linuxkit",
                    "name": "Ubuntu",
                    "platform": "ubuntu",
                    "version": "20.04.4 LTS (Focal Fossa)"
                }
            },
            "policy_id": "b524cbd0-b671-11ec-9278-35137f95496f",
            "type": "PERMANENT",
            "updated_at": "2022-04-11T13:19:22Z",
            "last_checkin_status": "online",
            "last_checkin": "2022-04-11T13:19:18Z",
            "default_api_key": "uXbDGIABELCmyzDwloJS:0pk0edMnSTeiCyi6CxG14A",
            "default_api_key_id": "uXbDGIABELCmyzDwloJS",
            "policy_output_permissions_hash": "a98b2704d96f3a72c77ee2e499898bc091d3c710d56a7b75c9f7f7b7b0f14f7b",
            "policy_revision_idx": 1,
            "policy_coordinator_idx": 1,
            "policy_revision": 1,
            "status": "online",
            "packages": []
        },
        {
            "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
            "access_api_key_id": "J0tFAYABicK5TYBjdnJC",
            "action_seq_no": [
                -1
            ],
            "active": true,
            "agent": {
                "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
                "version": "8.3.0"
            },
            "enrolled_at": "2022-04-06T23:46:11Z",
            "local_metadata": {
                "elastic": {
                    "agent": {
                        "build.original": "8.3.0-SNAPSHOT (build: 12eb476712eed1b9b6b94f2b8c807df4ccac3b3b at 2022-04-06 16:14:16 +0000 UTC)",
                        "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
                        "log_level": "info",
                        "snapshot": true,
                        "upgradeable": false,
                        "version": "8.3.0"
                    }
                },
                "host": {
                    "architecture": "x86_64",
                    "hostname": "372f76872ca3",
                    "id": "",
                    "ip": [
                        "127.0.0.1/8",
                        "172.17.0.99/16"
                    ],
                    "mac": [
                        "02:42:ac:11:00:63"
                    ],
                    "name": "372f76872ca3"
                },
                "os": {
                    "family": "debian",
                    "full": "Ubuntu focal(20.04.4 LTS (Focal Fossa))",
                    "kernel": "4.15.0-1032-gcp",
                    "name": "Ubuntu",
                    "platform": "ubuntu",
                    "version": "20.04.4 LTS (Focal Fossa)"
                }
            },
            "policy_id": "policy-elastic-agent-on-cloud",
            "type": "PERMANENT",
            "default_api_key_id": "FrZMAYABELCmyzDwcwpl",
            "policy_output_permissions_hash": "1c50ec8787bd4cae8cb3e1325361e3ba281f88b698f9c401c0fd7846ff2aefb3",
            "default_api_key": "FrZMAYABELCmyzDwcwpl:_I6_CL8tR7aQ6QJEZcMxhg",
            "policy_revision_idx": 4,
            "policy_coordinator_idx": 1,
            "updated_at": "2022-04-11T13:19:42Z",
            "last_checkin_status": "online",
            "last_checkin": "2022-04-11T13:19:35Z",
            "policy_revision": 4,
            "status": "online",
            "packages": []
        }
    ],
    "total": 2,
    "totalInactive": 0,
    "page": 1,
    "perPage": 20
}

I do see system/metrics data in my Metrics System Overview dashboard for the agent, and logs in its Logs tab, so I'm not sure what's missing to get past the loader.

criamico · 2022-04-11T13:35:50Z

I'm having trouble getting past the "Confirm incoming data" step in Cloud.

I'm enrolling an agent in a basic Agent Policy that just includes the system integration, and I'm running the agent on my Macbook via docker, e.g.
docker run --rm --add-host elasticsearch.local:192.168.65.2 \
  -e FLEET_URL=https://6e3f3c836ed0d22d3db21117a0894f2f.fleet.us-west2.gcp.elastic-cloud.com:443\
  -e FLEET_ENROLL=true \
  -e FLEET_ENROLLMENT_TOKEN=MThjV0JJQUJFTENteXpEd0xBTDI6ZUZSRHpvVmlTUGVPWVFHWkhHTFZ3Zw== \
  docker.elastic.co/beats/elastic-agent:8.2.0-SNAPSHOT
My agent starts up as expected, and Fleet reports that it's enrolled, but the "Confirm incoming data" spinner never goes away. I let it sit for 15ish minutes with no change.

Here's what I think is the relevant polling request from my network tab:

/api/fleet/agents?page=1&perPage=20&showInactive=false&showUpgradeable=false
I do see system/metrics data in my Metrics System Overview dashboard for the agent, and logs in its Logs tab, so I'm not sure what's missing to get past the loader.

Ok, so there's still some problem there. The polling request is similar to this one/api/fleet/agent_status/data?agentsIds=cf852616-61d9-4318-bf9f-fcfb3d72042d and should happen every 5s until some data is retrieved. Here's a short video of the functionality on my local:

Screen.Recording.2022-04-11.at.15.23.43.mov

The other thing that I had to do to see the data is to check that the fleet server host in the settings has the correct IP (http://DOCKERHOST_IP:8220) and I also pass it to the docker command (in addition to your command):

-e FLEET_URL=http://$DOCKERHOST_IP:8220 \

juliaElastic · 2022-04-11T13:54:39Z

should the labels be updated to v8.3?

I think they want it merged for 8.2, but I'll check again.

I see, even so, v8.3 should be added so that it is merged to main branch as well. v8.2 can remain if this needs to land in 8.2 too.

criamico · 2022-04-11T14:45:24Z

@juliaElastic @kpollich I added a check that should solve the problem with the fail retries in the incoming data component. I'm filtering out agents that have{data: false} in the response to /api/fleet/agent_status/data?agentsIds={agent_ids} query and then I'm setting incomingData to the filtered array; this way it should keep polling until it gets valid data.

juliaElastic · 2022-04-11T14:57:20Z

@juliaElastic @kpollich I added a check that should solve the problem with the fail retries in the incoming data component. I'm filtering out agents that have{data: false} in the response to /api/fleet/agent_status/data?agentsIds={agent_ids} query and then I'm setting incomingData to the filtered array; this way it should keep polling until it gets valid data.

I tested and the polling works for me now, eventually I see the data confirmed on the flyout.

juliaElastic · 2022-04-11T14:58:30Z

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/use_get_agent_incoming_data.tsx

- setIsLoading(false);
+ // filter out agents that have `data = false` and keep polling
+ const filtered = data?.items.filter((item) => {
+ const key = Object.keys(item)[0];


in case of multiple agentIds being queried, do they come in separate objects in items array? so we are not missing anything by taking the first key only, right?

No there's no problem there, the schema is something like
[ { 'agentid1': { data: true }, { 'agentid2': { data: false }, ... ]

so there's only one key for each item of the array.
Here is where this schema is defined:

kibana/x-pack/plugins/fleet/server/services/agents/status.ts

Line 166 in 64910b3

agentIdsWithData.includes(id) ? { [id]: { data: true } } : { [id]: { data: false } }

juliaElastic

LGTM, thanks for fixing the review comments

criamico · 2022-04-11T15:37:41Z

LGTM, thanks for fixing the review comments

Thanks a lot for your help! It's better to catch those issues early :)

kibana-ci · 2022-04-11T16:08:00Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	579	593	+14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	684.3KB	692.7KB	+8.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	110.9KB	110.9KB	+4.0B

History

💚 Build #37223 succeeded 25a8750
💚 Build #37185 succeeded 7c7c60e
💛 Build #36920 was flaky f3ac9db
💚 Build #36689 succeeded af9f8e8
💚 Build #36542 succeeded ec2b052
💔 Build #36508 failed d3a854d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

* [Fleet] Redesign and refactor agent flyout * Further refactoring * More refactoring and some bug fixing * bug fixing * Fix step tests + skip standalone tab tests * Use test-subj for agent policy code block to fix cypress tests * Fixing small issues on rendering * Fix broken import; Fix button in incoming data comp * Fix loading; add button in incoming data step * Fix some failures * Fix tests * Fix checks * Address code review comments; add retry logic to incoming data component * Fix download link * Check enrolled agents in last 10 minutes * Filter out agents with data=false from incoming data Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kyle Pollich <[email protected]> (cherry picked from commit 6e8d979)

kibanamachine · 2022-04-11T16:14:43Z

💚 All backports created successfully

Status	Branch	Result
✅	8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

* [Fleet] Redesign and refactor agent flyout * Further refactoring * More refactoring and some bug fixing * bug fixing * Fix step tests + skip standalone tab tests * Use test-subj for agent policy code block to fix cypress tests * Fixing small issues on rendering * Fix broken import; Fix button in incoming data comp * Fix loading; add button in incoming data step * Fix some failures * Fix tests * Fix checks * Address code review comments; add retry logic to incoming data component * Fix download link * Check enrolled agents in last 10 minutes * Filter out agents with data=false from incoming data Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kyle Pollich <[email protected]> (cherry picked from commit 6e8d979) Co-authored-by: Cristina Amico <[email protected]>

joshdover linked an issue Mar 23, 2022 that may be closed by this pull request

[Fleet] Agent Install Flyout Redesign #125534

Closed

20 tasks

criamico self-assigned this Mar 23, 2022

criamico changed the title ~~Agent flyout/refactor flyout~~ [Fleet] Redesign agent flyout Mar 23, 2022

criamico added Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 release_note:enhancement backport:skip This commit does not require backporting labels Mar 24, 2022

criamico marked this pull request as ready for review March 24, 2022 17:42

criamico requested a review from a team as a code owner March 24, 2022 17:42

juliaElastic reviewed Mar 28, 2022

View reviewed changes

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/instructions.tsx Outdated Show resolved Hide resolved

juliaElastic reviewed Mar 28, 2022

View reviewed changes

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/agent_policy_select_create.tsx Show resolved Hide resolved

juliaElastic reviewed Mar 28, 2022

View reviewed changes

x-pack/plugins/fleet/public/components/enrollment_instructions/manual/index.tsx Outdated Show resolved Hide resolved

juliaElastic reviewed Mar 28, 2022

View reviewed changes

nchaulet reviewed Mar 28, 2022

View reviewed changes

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/confirm_agent_enrollment.tsx Outdated Show resolved Hide resolved

kpollich reviewed Mar 28, 2022

View reviewed changes

Check enrolled agents in last 10 minutes

25a8750

criamico requested a review from joshdover April 11, 2022 10:45

criamico added the v8.3.0 label Apr 11, 2022

Filter out agents with data=false from incoming data

75f97e1

juliaElastic reviewed Apr 11, 2022

View reviewed changes

juliaElastic approved these changes Apr 11, 2022

View reviewed changes

criamico merged commit 6e8d979 into elastic:main Apr 11, 2022

kibanamachine mentioned this pull request Apr 11, 2022

[8.2] [Fleet] Redesign agent flyout (#128381) #129911

Merged

jen-huang mentioned this pull request Apr 13, 2022

[Fleet] k8 instructions is lost after agent flyout redesign #130201

Closed

criamico mentioned this pull request Apr 14, 2022

[Fleet] Add missing step showing K8 instructions for managed enrollment #130295

Merged

3 tasks

criamico deleted the agent_flyout/refactor_flyout branch July 12, 2022 15:00

oren-zohar mentioned this pull request Aug 16, 2022

Fix templating string in standalone manifest #138858

Merged

9 tasks

tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Redesign agent flyout #128381

[Fleet] Redesign agent flyout #128381

criamico commented Mar 23, 2022 •

edited

Loading

joshdover commented Mar 23, 2022

criamico commented Mar 24, 2022

elasticmachine commented Mar 24, 2022

juliaElastic commented Mar 28, 2022 •

edited

Loading

juliaElastic commented Mar 28, 2022 •

edited

Loading

criamico commented Mar 28, 2022

criamico commented Mar 28, 2022 •

edited

Loading

criamico commented Mar 28, 2022

juliaElastic commented Mar 28, 2022

juliaElastic commented Mar 28, 2022 •

edited

Loading

juliaElastic Mar 28, 2022

juliaElastic Mar 28, 2022

criamico commented Mar 28, 2022 •

edited

Loading

criamico commented Mar 28, 2022

kpollich left a comment

juliaElastic commented Mar 29, 2022

juliaElastic commented Mar 29, 2022 •

edited

Loading

joshdover commented Apr 11, 2022

joshdover commented Apr 11, 2022

juliaElastic commented Apr 11, 2022

juliaElastic commented Apr 11, 2022

criamico commented Apr 11, 2022

criamico commented Apr 11, 2022

kpollich commented Apr 11, 2022 •

edited

Loading

criamico commented Apr 11, 2022

juliaElastic commented Apr 11, 2022

criamico commented Apr 11, 2022

juliaElastic commented Apr 11, 2022

juliaElastic Apr 11, 2022

criamico Apr 11, 2022 •

edited

Loading

juliaElastic left a comment

criamico commented Apr 11, 2022 •

edited

Loading

kibana-ci commented Apr 11, 2022

kibanamachine commented Apr 11, 2022

[Fleet] Redesign agent flyout #128381

[Fleet] Redesign agent flyout #128381

Conversation

criamico commented Mar 23, 2022 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

joshdover commented Mar 23, 2022

criamico commented Mar 24, 2022

elasticmachine commented Mar 24, 2022

juliaElastic commented Mar 28, 2022 • edited Loading

juliaElastic commented Mar 28, 2022 • edited Loading

criamico commented Mar 28, 2022

criamico commented Mar 28, 2022 • edited Loading

criamico commented Mar 28, 2022

juliaElastic commented Mar 28, 2022

juliaElastic commented Mar 28, 2022 • edited Loading

juliaElastic Mar 28, 2022

Choose a reason for hiding this comment

juliaElastic Mar 28, 2022

Choose a reason for hiding this comment

criamico commented Mar 28, 2022 • edited Loading

criamico commented Mar 28, 2022

kpollich left a comment

Choose a reason for hiding this comment

juliaElastic commented Mar 29, 2022

juliaElastic commented Mar 29, 2022 • edited Loading

joshdover commented Apr 11, 2022

joshdover commented Apr 11, 2022

juliaElastic commented Apr 11, 2022

juliaElastic commented Apr 11, 2022

criamico commented Apr 11, 2022

criamico commented Apr 11, 2022

kpollich commented Apr 11, 2022 • edited Loading

criamico commented Apr 11, 2022

juliaElastic commented Apr 11, 2022

criamico commented Apr 11, 2022

juliaElastic commented Apr 11, 2022

juliaElastic Apr 11, 2022

Choose a reason for hiding this comment

criamico Apr 11, 2022 • edited Loading

Choose a reason for hiding this comment

juliaElastic left a comment

Choose a reason for hiding this comment

criamico commented Apr 11, 2022 • edited Loading

kibana-ci commented Apr 11, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

kibanamachine commented Apr 11, 2022

💚 All backports created successfully

Questions ?

criamico commented Mar 23, 2022 •

edited

Loading

juliaElastic commented Mar 28, 2022 •

edited

Loading

juliaElastic commented Mar 28, 2022 •

edited

Loading

criamico commented Mar 28, 2022 •

edited

Loading

juliaElastic commented Mar 28, 2022 •

edited

Loading

criamico commented Mar 28, 2022 •

edited

Loading

juliaElastic commented Mar 29, 2022 •

edited

Loading

kpollich commented Apr 11, 2022 •

edited

Loading

criamico Apr 11, 2022 •

edited

Loading

criamico commented Apr 11, 2022 •

edited

Loading