[Response Ops] Fixing issue with empty row in execution log table when rule is running #129151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
force-pushed
the
alerting/exclude-execute-start
branch
2 times, most recently
from
4009c45
to
0a2686a
Compare
…g/exclude-execute-start
ymao1
force-pushed
the
alerting/exclude-execute-start
branch
from
bdb40f4
to
1cb70d4
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
ymao1
changed the title
ymao1
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
mikecote
approved these changes
Apr 1, 2022
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 1, 2022
…n rule is running (#129151) (#129231) * Excluding execute-start events from exec log * Fixing checks * Adding functional tests (cherry picked from commit 8291a22) Co-authored-by: Ying Mao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #129126
Summary
Updates the exec log aggregation to exclude
execute-startevents. This prevents an empty row from being returned for currently running rule executions.To Verify
See description in #129126 to reproduce the issue. With this branch, you should no longer see an empty row returned while a rule is mid-execution.
Checklist