[Lens] accuracy mode for Top Values

[drewdaemon]

Summary

Resolves #117909

Screen.Recording.2022-04-01.at.3.46.22.PM.mov

Help icon:

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

[drewdaemon]

@elasticmachine merge upstream

[drewdaemon]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[drewdaemon]

@flash1293 what is the official process for removing a translation string that is no longer used?

[flash1293]

While testing this I noticed that the multi terms agg is actually not reporting precision errors - it's missing this implementation:

kibana/src/plugins/data/common/search/aggs/buckets/terms.ts

Line 77 in 244d27b

hasPrecisionError: (aggBucket) => Boolean(aggBucket?.doc_count_error_upper_bound),

Since you are working on this anyway right now, could you add it?

[drewdaemon]

@elasticmachine merge upstream

[gchaps]

Here are some suggestions for the copy in the tooltip and the warning:

Tooltip

Improves results for high-cardinality data, but increases the load on the Elasticsearch cluster.

Warning 1

Top 5 values for customer_first_name.keyword might be an approximation.
You can enable accuracy mode for more precise results, but note that it
increases the load on the Elasticsearch cluster. Learn more.

Enable accuracy mode (use sentence case)

Warning 2

Top 5 values for customer_first_name.keyword might be an approximation.
For more precise results, try increasing the number of top values or using filters instead. Learn more.

[drewdaemon]

@gchaps thanks for those suggestions. Way better than what I had.

[gchaps]

@andrewctate In the updated screenshots, "top 5 values" is repeated in the text. Is that just for the example you are showing? I'm not sure where {name} is coming from.

[drewdaemon]

@gchaps thanks for catching that 🤦‍♂️ . Here's the real deal:

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 0afddb7
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
data	2809	2811	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.1MB	1.1MB	+1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	422.6KB	423.1KB	+563.0B

Unknown metric groups

API count

id	before	after	diff
data	3419	3421	+2

History

• 💔 Build #38801 failed 5ab2829
• 💔 Build #38792 failed 5e8edd1
• 💔 Build #38419 failed bf4e981
• 💚 Build #38356 succeeded 500a3d6
• 💛 Build #38049 was flaky 4a2d41d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[gchaps]

Text LGTM

[ppisljar]

app services code LGTM

[flash1293]

Tested again and works well now even for multi field terms, LGTM 👍