Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY] Add addTimeMarker arg #131495

Merged

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa commented May 4, 2022

Completes part of #127115

Summary

Add posibility to show current time marker by using new addTimeMarker arg.

image

Testing notes

kibana
| selectFilter
| esaggs index={indexPatternLoad id="90943e30-9a47-11e8-b64d-95841ca0b247"} aggs={aggDateHistogram id="0" enabled=true schema="segment" field="@timestamp" useNormalizedEsInterval=true interval="auto" drop_partials=false min_doc_count=0 extended_bounds={extendedBounds} extendToTimeRange=true} aggs={aggCount id="1" enabled=true schema="metric" emptyAsNull=true} metricsAtAllLevels=false partialRows=false timeFields="@timestamp" | lens_rename_columns idMap="{\"col-0-0\":{\"label\":\"@timestamp\",\"dataType\":\"date\",\"operationType\":\"date_histogram\",\"sourceField\":\"@timestamp\",\"isBucketed\":true,\"scale\":\"interval\",\"params\":{\"interval\":\"auto\",\"includeEmptyRows\":true,\"dropPartials\":false},\"id\":\"33916a2a-2df2-4be7-b2cf-f479f7f8bab7\"},\"col-1-1\":{\"label\":\"Count of records\",\"dataType\":\"number\",\"operationType\":\"count\",\"isBucketed\":false,\"scale\":\"ratio\",\"sourceField\":\"___records___\",\"params\":{\"emptyAsNull\":true},\"id\":\"a97365df-f1f2-48b4-8dfd-4c251628b09e\"}}"
| xyVis seriesType="bar" xAccessor="33916a2a-2df2-4be7-b2cf-f479f7f8bab7" accessors="a97365df-f1f2-48b4-8dfd-4c251628b09e" addTimeMarker=true
| render

@VladLasitsa VladLasitsa self-assigned this May 4, 2022
@Kuznietsov Kuznietsov mentioned this pull request May 10, 2022
31 tasks
@VladLasitsa VladLasitsa added Feature:XYAxis XY-Axis charts (bar, area, line) Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 labels May 10, 2022
@Kuznietsov Kuznietsov changed the title Add addTimeMarker arg [XY] Add addTimeMarker arg May 11, 2022
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@VladLasitsa VladLasitsa added the WIP Work in progress label May 17, 2022
@VladLasitsa VladLasitsa marked this pull request as ready for review May 17, 2022 13:59
@VladLasitsa VladLasitsa requested a review from a team as a code owner May 17, 2022 13:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@Kuznietsov Kuznietsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code mostly LGTM 👍 Tested locally.

Screenshot 2022-05-17 at 18 21 08

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionXY 98 99 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressionXY 129 130 +1
lens 493 494 +1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionXY 75.0KB 79.5KB +4.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionXY 31.6KB 31.8KB +173.0B
Unknown metric groups

API count

id before after diff
expressionXY 139 140 +1
lens 570 571 +1
total +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa merged commit f75b6fa into elastic:main May 20, 2022
j-bennet pushed a commit to j-bennet/kibana that referenced this pull request Jun 2, 2022
* Add `addTimeMarker` arg

* Some fixes

* Update validation

* Fix snapshots

* Some fixes after merge

* Add unit tests

* Fix CI

* Update src/plugins/chart_expressions/expression_xy/public/helpers/data_layers.tsx

Co-authored-by: Yaroslav Kuznietsov <[email protected]>

* Fixed tests

* Fix checks

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yaroslav Kuznietsov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:XYAxis XY-Axis charts (bar, area, line) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants