Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain log rate spikes: Disable UI/APIs. #132589

Merged
merged 1 commit into from
May 20, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented May 20, 2022

Summary

Part of #136265.

This disables the UI and APIs for Explain log rate spikes in the ML plugin since it will not be part of 8.3. Once 8.3 has been branched off, we can reenable it in main. This also adds a check to the API integration tests to run the tests only when the hard coded feature flag is set to true.

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 20, 2022
@walterra walterra self-assigned this May 20, 2022
@walterra walterra requested a review from a team as a code owner May 20, 2022 09:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #39 / rules security and spaces enabled: basic ruleRegistryAlertsSearchStrategy logs should return alerts from log rules
  • [job] [logs] FTR Configs #28 / security app - OIDC interactions URL capture "before all" hook for "can login preserving original URL"

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit b3aee17 into elastic:main May 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 20, 2022
@walterra walterra deleted the ml-aiops-disable-8-3 branch May 20, 2022 10:56
j-bennet pushed a commit to j-bennet/kibana that referenced this pull request Jun 2, 2022
This disables the UI and APIs for Explain log rate spikes in the ML plugin since it will not be part of 8.3. Once 8.3 has been branched off, we can reenable it in main. This also adds a check to the API integration tests to run the tests only when the hard coded feature flag is set to true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants