Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph] Migrate from savedObjectsClient to dataViews and fix the displayed data view name #135142

Merged
merged 5 commits into from
Jun 28, 2022
Merged

[Graph] Migrate from savedObjectsClient to dataViews and fix the displayed data view name #135142

merged 5 commits into from
Jun 28, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Jun 24, 2022 •
edited
Loading

Closes #131378

Summary

This PR refactors exiting code to use newer dataViews API and it fixes the displayed Data View name for the data source button.

To test:

  • Start ES in trial mode
  • Navigate to Graph app
  • Check that it's working as before and user can switch data views

@jughosta jughosta added release_note:fix Feature:Graph Graph application feature backport:skip This commit does not require backporting Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) v8.4.0 labels Jun 24, 2022
@jughosta jughosta self-assigned this Jun 24, 2022
@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@jughosta jughosta marked this pull request as ready for review June 27, 2022 09:49
@jughosta jughosta requested a review from a team as a code owner June 27, 2022 09:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-graph (Feature:Graph)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 475.3KB 475.1KB -238.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

kertal
kertal approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested in cloud deployment, works as expected, that for also improving the displayed name 👍 ... we should take advantage of the data view picker somewhere in the future

@jughosta jughosta merged commit f308aa1 into elastic:main Jun 28, 2022
@jughosta jughosta deleted the 131378-migrate-from-saved-objects-client branch June 28, 2022 15:00
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Jun 28, 2022
@jughosta @kibanamachine @patrykkopycinski
[Graph] Migrate from savedObjectsClient to dataViews and fix the disp…
7bdf572 
…layed data view name (elastic#135142)

* [Graph] Migrate from savedObjectsClient to dataViews

* [Graph] Update tests

* [Graph] Fix "no data views" view

Co-authored-by: Kibana Machine <[email protected]>
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment Feature:Graph Graph application feature release_note:fix Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Graph] Make use of data view service instead of Saved Object API
6 participants
@jughosta @elasticmachine @kibana-ci @kertal @tylersmalley @kibanamachine