Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded angular, elasticsearchjs and elasticjs #1377

Closed
wants to merge 4 commits into from

Conversation

tomcashman
Copy link

Angular is now at 1.2.20
Elasticsearch JS now included
Updated to the latest elasticjs

This commit is similar to #1222 except I opted to hide the raw elasticseach client behind the (custom?) EJS angular service to simplify the upgrade. I needed to implement these changes as I require the aggregation functions in elasticsearch so that I can implement a new panel for work. I have tested this commit on our staging servers against our existing reports.

tomcashman and others added 4 commits July 21, 2014 17:59
Angular is now at 1.2.20
Elasticsearch JS now included
Updated to the latest elasticjs

This commit has been tested on our staging servers against our existing
reports.
Fixed issue with inspector not pretty printing the JSON output.
@chenryn
Copy link
Contributor

chenryn commented Aug 20, 2014

new elastic.js donot support searchType? I found multifieldhistogram use reqeust.searchType("count"), but seems cann't use if I merge this upgrade.

@yang66
Copy link

yang66 commented Aug 21, 2014

@chenryn follow your fork to here. I deploy your kibana fork but got this error:

TypeError: Cannot read property 'get' of undefined
    at getVersions (http://localhost:8080/app/services/esVersion.js:31:34)
    at init (http://localhost:8080/app/services/esVersion.js:23:7)
    at new <anonymous> (http://localhost:8080/app/services/esVersion.js:195:10)
    at invoke (http://localhost:8080/vendor/angular/angular.js:3918:17)
    at Object.instantiate (http://localhost:8080/vendor/angular/angular.js:3929:23)
    at Object.<anonymous> (http://localhost:8080/vendor/angular/angular.js:3797:24)
    at Object.invoke (http://localhost:8080/vendor/angular/angular.js:3918:17)
    at http://localhost:8080/vendor/angular/angular.js:3760:37
    at getService (http://localhost:8080/vendor/angular/angular.js:3882:39)
    at invoke (http://localhost:8080/vendor/angular/angular.js:3909:13) angular.js:9997

help..

@chenryn
Copy link
Contributor

chenryn commented Aug 21, 2014

@coogleyou maybe you need to clear your browser cache. I have saw this warnings before, but no more when I prepare to debug it the second day...

@w33ble w33ble closed this Oct 6, 2014
@spalger
Copy link
Contributor

spalger commented Oct 6, 2014

Woops! Sorry about that! We recently replaced the master branch with Kibana 4. This action force closed all of the old pull requests against master. We will be reviewing these on a case-by-case basis and creating new tickets as necessary.

The good news is that many long requested features can be found in Kibana 4, and we're being entirely open about our roadmap. Check out the roadmap tickets (which we're still filling in) here.

If you're looking for the old Kibana 3 code you can find it here.

@w33ble
Copy link
Contributor

w33ble commented Oct 8, 2014

We're stopping development on Kibana 3 and focusing on Kibana 4 going forward. Kibana 4 will be using the current version of the ES Javascript client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants