Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix max width issue in policy editor #145917

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

kpollich
Copy link
Member

Summary

Closes #145909

Fix max width issue with Fleet policy editor, likely due to upstream EUI change and some custom CSS we had to fiddle with some flex widths.

Screen.Recording.2022-11-21.at.2.09.05.PM.mov

Also fixed some typos/leftover code that was floating around here.

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 21, 2022
@kpollich kpollich self-assigned this Nov 21, 2022
@kpollich kpollich requested a review from a team as a code owner November 21, 2022 19:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 889.2KB 888.9KB -295.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpollich kpollich merged commit 1b1a2e9 into elastic:main Nov 21, 2022
@kpollich kpollich deleted the 145909-fix-policy-editor-width branch November 21, 2022 20:50
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Policy editor width bug
5 participants