Timelion query language support for scripted fields #14700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Feature:Timelion
| @@ -27,7 +27,7 @@ export default new Datasource('es', { | |||
| { | |||
| name: 'index', | |||
| types: ['string', 'null'], | |||
| help: 'Index to query, wildcards accepted' | |||
| help: 'Index to query, wildcards accepted. Provide Index Pattern name for scripted field support.' | |||
There was a problem hiding this comment.
This is somewhat of odd, and I might be missing something.
Have you tested this with the default logstash-* index-pattern, from the examples with makelogs? I tried it, and no matching saved-objects come up. Creating a new index pattern, something like log*, does make it work.
| }; | ||
| } else { | ||
| dateAgg.time_buckets.aggs[metricName][metric[0]] = { field: metric[1] }; | ||
| } |
There was a problem hiding this comment.
thoughts on extracting this boilerplate in separate module, shared with buildRequest? There's some overlap
const scriptedField = scriptedFields.find(field => {
return field.name === clause[0];
});
if (scriptedField) {
termsAgg.script = {
inline: scriptedField.script,
lang: scriptedField.lang
};
} else {
termsAgg.field = clause[0];
}
nreese
force-pushed
the
timelion_scripted
branch
from
9645f26
to
0cd8843
Compare
|
@thomasneirynck Turns out the As a work around, I can remove characters like |
|
@nreese oh so funny, known issue. work-around sounds good. i think that'll be better than just transparently fail. it'd also be a weird limitation to document. |
thomasneirynck
approved these changes
Nov 7, 2017
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Nov 8, 2017
* update run REST API to fetch index pattern and use script for scripted fields * allow scripted fields for elasticsearch split argument * add test cases for scripted fields to elasticsearch test * update help text for .es() index argument * move scripted field check into common file, remove stop characters from index pattern title * use space instead of nothing for replacing stop chars * wrap index name in quotes instead of removing dash character
nreese
added a commit
that referenced
this pull request
Nov 8, 2017
* update run REST API to fetch index pattern and use script for scripted fields * allow scripted fields for elasticsearch split argument * add test cases for scripted fields to elasticsearch test * update help text for .es() index argument * move scripted field check into common file, remove stop characters from index pattern title * use space instead of nothing for replacing stop chars * wrap index name in quotes instead of removing dash character
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 20, 2017
* update run REST API to fetch index pattern and use script for scripted fields * allow scripted fields for elasticsearch split argument * add test cases for scripted fields to elasticsearch test * update help text for .es() index argument * move scripted field check into common file, remove stop characters from index pattern title * use space instead of nothing for replacing stop chars * wrap index name in quotes instead of removing dash character
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Dec 1, 2017
* update run REST API to fetch index pattern and use script for scripted fields * allow scripted fields for elasticsearch split argument * add test cases for scripted fields to elasticsearch test * update help text for .es() index argument * move scripted field check into common file, remove stop characters from index pattern title * use space instead of nothing for replacing stop chars * wrap index name in quotes instead of removing dash character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9022
Adds scripted field support to timelion
.es()for themetricandsplitarguments