-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Add link from Index management #152640
[Discover] Add link from Index management #152640
Conversation
…-ref HEAD~1..HEAD --fix'
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really cool feature. Thanks for working on this @kertal!
One thought I had is it might be better to display the link in the details panel, rather than the table. If a user has a lot of indices/data streams, it be a little overwhelming having the same icon for each row. Although the tradeoff is it's not as discoverable (no pun intended 😅 ).
I see the PR is still in draft. Was your expectation just to get initial thoughts on this feature?
Fine with that, I think having the possibility to link to the documents of the indices is what's important. we can integrate on that.
You know I started this to demonstrate how easy it is to link to Discover. Also it was always something I thought was missing, a list of indices needs a button to show the documents of the indices. So why did I not iterate on it? Lack of time. I will apply your suggestion, which is a pretty safe path for adding this. |
@elasticmachine merge upstream |
…/kibana into link-index-management-to-discover
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @kertal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kertal! Latest LGTM.
Would it be possible to detect that an index pattern has a time field and show a histogram on Discover page? Or at least for data streams. |
We have something like this in Discover:
But it's just looking for the field
WDYT? I do agree it would be convenient to have something like this, just thinking if we shouldn't aim higher for more improvement |
@kertal Sure, I agree with an iterative approach! I was only concerned that showing Discover page without time based sorting and histogram for time-based indices might appear unexpected/buggy for users. If it's not the case then LGTM 👍 |
I do agree we should further improve this area and will open an issue for that, thx for you valuable input! 👍 |
Summary
While preparing a presentation about linking to Discover I figured out it would be nice the provide a link from index management to Discover, so users could directly look at the documents of their indices. The link is visible in the flyout showing details about a index or data stream, and the button opens up the selected index / data stream as an ad-hoc data view in Discover. No data view persistence upfront is needed.
Kapture.2023-03-24.at.22.55.58.mp4
Checklist
Delete any items that are not applicable to this PR.