Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add timelines installation to the new rule upgrade/install endpoints #159694

Merged
merged 1 commit into from
Jun 15, 2023
Merged

[Security Solution] Add timelines installation to the new rule upgrade/install endpoints #159694

merged 1 commit into from
Jun 15, 2023

Conversation

xcrzx
Copy link
Contributor

@xcrzx xcrzx commented Jun 14, 2023 •
edited
Loading

Resolves: #152860

To replicate the behavior of the legacy prebuilt rule endpoint, this PR introduces a call to install prebuilt timeline templates each time any of the following endpoints are invoked:

  • POST /internal/detection_engine/prebuilt_rules/installation/_perform
  • POST /internal/detection_engine/prebuilt_rules/upgrade/_perform

@xcrzx xcrzx added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules v8.9.0 labels Jun 14, 2023
@xcrzx xcrzx self-assigned this Jun 14, 2023
@xcrzx xcrzx marked this pull request as ready for review June 14, 2023 13:26
@xcrzx xcrzx requested a review from a team as a code owner June 14, 2023 13:26
@xcrzx xcrzx requested a review from spong June 14, 2023 13:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@xcrzx xcrzx requested review from jpdjere and removed request for spong June 14, 2023 13:26
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #6 / Endpoint Exceptions workflows from Alert Should be able to create and close single Endpoint exception from overflow menu

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 409 413 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 492 496 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @xcrzx

jpdjere
jpdjere approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@jpdjere jpdjere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for so quickly taking care of this

@xcrzx xcrzx merged commit 16193c6 into elastic:main Jun 15, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 15, 2023
@xcrzx xcrzx deleted the timelines-install branch June 15, 2023 09:57
@jpdjere jpdjere mentioned this pull request Jun 21, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdjere jpdjere jpdjere approved these changes

Assignees

@xcrzx xcrzx

Labels
backport:skip This commit does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Feature:Rule Management Security Solution Detection Rule Management release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.0
Projects
None yet
Milestone
No milestone
5 participants
@xcrzx @elasticmachine @kibana-ci @jpdjere @kibanamachine