Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix flaky hover actions test #166492

Closed
wants to merge 3 commits into from
Closed

[Security Solution] Fix flaky hover actions test #166492

wants to merge 3 commits into from

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Sep 14, 2023 •
edited
Loading

Summary

This fixes some of the flaky hover actions tests

@lgestc lgestc force-pushed the me-vs-flaky-hover-actions branch 4 times, most recently from 3d1efa7 to dc45803 Compare September 15, 2023 06:58
@stephmilovic stephmilovic mentioned this pull request Sep 18, 2023
Closed
@lgestc lgestc marked this pull request as ready for review September 19, 2023 15:37
@lgestc lgestc requested a review from a team as a code owner September 19, 2023 15:37
@lgestc lgestc added Team:Threat Hunting:Explore 8.11 candidate backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Sep 19, 2023
stephmilovic
stephmilovic approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, amazing work! Going to be coming to you for help with cypress in the future 🤪

@lgestc
Copy link
Contributor Author

lgestc commented Oct 1, 2023 •
edited
Loading

Hey @stephmilovic , something changed on the fixture loading side I think, do you know what precisely? :D
It did not complain about the default index before

image

The above is a screenshot from cypress, running the hover actions test

@lgestc lgestc force-pushed the me-vs-flaky-hover-actions branch 2 times, most recently from 53f866d to 7e2cdb5 Compare October 4, 2023 08:57
lgestc
lgestc commented Oct 18, 2023
View reviewed changes
x-pack/test/security_solution_cypress/cypress/tasks/network/flows.ts
const actionsButtonInPortal = '[data-euiportal="true"] button[data-test-subj*="cellActions"]';

// Check if actions portal element is visible
cy.get('body').then(($body) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@logeekal

@stephmilovic
Copy link
Contributor

Hey @stephmilovic , something changed on the fixture loading side I think, do you know what precisely? :D It did not complain about the default index before

image

The above is a screenshot from cypress, running the hover actions test

sorry i missed this ping. Do you need the maps for the test? This doesn't mean something is wrong with event data, just packetbeat

@stephmilovic
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 25, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #1 / EcsMapping should hide and show ecs mappings on Advanced accordion click should hide and show ecs mappings on Advanced accordion click
  • [job] [logs] Serverless Osquery Cypress Tests #1 / EcsMapping should properly show static values in form and results should properly show static values in form and results
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #2 / Hover actions Adds global filter - filter in Adds global filter - filter in
  • [job] [logs] Explore - Security Solution Cypress Tests #4 / Hover actions Adds global filter - filter in Adds global filter - filter in
  • [job] [logs] Explore - Security Solution Cypress Tests #4 / Hover actions Adds global filter - filter in Adds global filter - filter in
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #2 / Hover actions Adds global filter - filter in Adds global filter - filter in
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #2 / Hover actions Adds global filter - filter out Adds global filter - filter out
  • [job] [logs] Explore - Security Solution Cypress Tests #4 / Hover actions Adds global filter - filter out Adds global filter - filter out
  • [job] [logs] Explore - Security Solution Cypress Tests #4 / Hover actions Adds global filter - filter out Adds global filter - filter out
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #2 / Hover actions Adds global filter - filter out Adds global filter - filter out
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #2 / Hover actions Adds to timeline Adds to timeline
  • [job] [logs] Explore - Security Solution Cypress Tests #4 / Hover actions Adds to timeline Adds to timeline
  • [job] [logs] Explore - Security Solution Cypress Tests #4 / Hover actions Adds to timeline Adds to timeline
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #2 / Hover actions Adds to timeline Adds to timeline
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #2 / Hover actions Copy value Copy value
  • [job] [logs] Explore - Security Solution Cypress Tests #4 / Hover actions Copy value Copy value
  • [job] [logs] Explore - Security Solution Cypress Tests #4 / Hover actions Copy value Copy value
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #2 / Hover actions Copy value Copy value
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #2 / Hover actions Show topN Show topN
  • [job] [logs] Explore - Security Solution Cypress Tests #4 / Hover actions Show topN Show topN
  • [job] [logs] Explore - Security Solution Cypress Tests #4 / Hover actions Show topN Show topN
  • [job] [logs] Serverless Explore - Security Solution Cypress Tests #2 / Hover actions Show topN Show topN

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lgestc lgestc marked this pull request as draft November 29, 2023 16:45
@lgestc lgestc closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@MadameSheema MadameSheema Awaiting requested review from MadameSheema

Assignees
No one assigned
Labels
8.11 candidate backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgestc @stephmilovic @kibana-ci @kibanamachine