Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Search] Improve accessibility of flex width comboboxes #171439

Closed
wants to merge 5 commits into from
Closed

[Unified Search] Improve accessibility of flex width comboboxes #171439

wants to merge 5 commits into from

Commits on Nov 16, 2023

  1. [misc] Fix draggable disabled cursor CSS

    @cee-chen
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1b60ca8 View commit details
    Browse the repository at this point in the history

  2. [a11y] Focus the toggle dropdown button instead of entirely stranding… 

    … user focus
    @cee-chen
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    5c306c8 View commit details
    Browse the repository at this point in the history

  3. Restore behavior of reducing the combobox width on selection 

    - use `:has` rather than `:focus-within` for determining when the combobox should be embiggened, so that the dropdown arrow focus doesn't trigger the increase
    @cee-chen
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    596b377 View commit details
    Browse the repository at this point in the history

  4. Remove now-unnecessary extra onFocus handler

    @cee-chen
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    4d5d1a1 View commit details
    Browse the repository at this point in the history

  5. [TODO] input click workaround 

    - can be reverted once elastic#170716 merges
    @cee-chen
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0798463 View commit details
    Browse the repository at this point in the history