[Lens][Unified search] Auto expand comboboxes and popovers based on the content #171573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
release_note:skip
mbondyra
force-pushed
the
widen_eui_selectables_steps
branch
2 times, most recently
from
bc2a5b8
to
73acf81
Compare
mbondyra
force-pushed
the
widen_eui_selectables_steps
branch
2 times, most recently
from
00f0e43
to
b076dd1
Compare
mbondyra
force-pushed
the
widen_eui_selectables_steps
branch
from
b076dd1
to
2a7a0b7
Compare
mbondyra
force-pushed
the
widen_eui_selectables_steps
branch
from
512d3af
to
f628e1f
Compare
ThomThomson
approved these changes
Nov 21, 2023
…ana into widen_eui_selectables_steps
davismcphee
approved these changes
Nov 21, 2023
mbondyra
added
the
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
…ana into widen_eui_selectables_steps
…i_selectables_steps
4 tasks
mbondyra
changed the title
…i_selectables_steps
…ana into widen_eui_selectables_steps
dej611
reviewed
Nov 23, 2023
| }; | ||
|
|
||
| const handleFocus: React.FocusEventHandler<HTMLDivElement> = () => { |
There was a problem hiding this comment.
That's nice to get rid of this type of code 🎉
dej611
reviewed
Nov 23, 2023
packages/kbn-calculate-width-from-char-count/src/calculate_width_from_char_count.ts
Show resolved
Hide resolved
…i_selectables_steps # Conflicts: # x-pack/plugins/lens/tsconfig.json
This reverts commit feff1c7.
…i_selectables_steps
|
Thanks @dej611 I addressed your comments 😊 |
dej611
approved these changes
Nov 28, 2023
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes partially two remaining tasks from #168753
Fixes partially dataview issue from #170398
It stretches to maximum approximate 60 characters if any of the labels in the list is of this length. If the content doesn't need the container to stretch, it doesn't do it.
Field picker in Lens
minimum width:
auto-expanded width:
Layer data view picker in Lens
Data view picker in Unified Search
Data view picker in dashboard Create control flyout
Unified search data view select component (tested in maps)
Unified search field and value picker
Adds `panelMinWidth`, removes the custom flex width change behaviorNov-22-2023.14-20-48.mp4
Discover breakdown field
Removes the focus stretching and instead uses the panelMinWidth prop