Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] RFC for Prebuilt Rules Customization - Milestone 3 #171856

Merged
merged 62 commits into from
Apr 4, 2024
Merged

[Security Solution] RFC for Prebuilt Rules Customization - Milestone 3 #171856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
c0f2e05
RFC for Prebuilt Rules Customization - Phase 3 - Part 1
jpdjere Nov 23, 2023
053ecd6
Refactor: Updated schema definitions
jpdjere Feb 13, 2024
308709d
Refactor: Updated migration context
jpdjere Feb 13, 2024
b95a529
Refactor: Normalization on write
jpdjere Feb 13, 2024
a461cf5
Refactor: Add table for updating actions
jpdjere Feb 13, 2024
a29bea1
Refactor: removed code implementation details for update migrations
jpdjere Feb 13, 2024
5c72739
Refactor: Added Bulk editing rules section
jpdjere Feb 13, 2024
499dc4c
Refactor: KQL filters and the method section
jpdjere Feb 13, 2024
2265ba1
Refactor: Clean up endpoint modifications
jpdjere Feb 14, 2024
0647a4f
Refactor: Add section
jpdjere Feb 14, 2024
15795cb
Refactor: Further simplified endpoints
jpdjere Feb 14, 2024
eab1c4b
Refactor: Deleted importing cases table
jpdjere Feb 15, 2024
6363547
Refactor: Minor fix
jpdjere Feb 15, 2024
26c7fad
Refactor: Started rewriting based on rule_source_type and import feed…
jpdjere Feb 19, 2024
f2f5ffb
Refactor: Modified migration table and KQL filters to account for rul…
jpdjere Feb 19, 2024
e0ec4e0
Refactor: Started rewriting import logic
jpdjere Feb 19, 2024
28f5380
Refactor: Rewrote all sections to account for 'rule_source'
jpdjere Feb 21, 2024
6b6578a
Part 2: Started concrete diffs implementation
jpdjere Feb 21, 2024
89fe78a
Part 2: Add algorithm use cases
jpdjere Feb 22, 2024
275c36d
Part 2: Add algorithm for solving array changes
jpdjere Feb 22, 2024
440ac2a
Part 2: Typo
jpdjere Feb 22, 2024
5842ce7
Part 2: Merged array of strings and objects algorithms
jpdjere Feb 23, 2024
794d3bb
Part 2: Added changes to upgrade /_review and /_perform endpoints
jpdjere Feb 23, 2024
283c706
Part 2: Remove changes for endpoints and link to POC
jpdjere Feb 23, 2024
2ed015e
Part 2: cleanup
jpdjere Feb 25, 2024
3aa1ac5
Removed line
jpdjere Mar 4, 2024
08ac332
Rework status
jpdjere Mar 4, 2024
c7418a2
Add ToC
jpdjere Mar 4, 2024
9a18e16
Added pending changes
jpdjere Mar 12, 2024
f27c13d
Update status
jpdjere Mar 18, 2024
30fc99f
Addressing feedback
jpdjere Mar 18, 2024
2e0cd26
Addressing feedback
jpdjere Mar 18, 2024
184eb02
Addressing feedback
jpdjere Mar 18, 2024
c073689
Addressing feedback
jpdjere Mar 18, 2024
e722c10
Addressing feedback
jpdjere Mar 18, 2024
072d009
Addressing feedback
jpdjere Mar 18, 2024
9481602
Addressing feedback
jpdjere Mar 18, 2024
c0da34f
Added table for migration type
jpdjere Mar 18, 2024
582bd8e
Addressing feedback
jpdjere Mar 18, 2024
ac6ac12
Addressing feedback
jpdjere Mar 18, 2024
08c945e
Addressing feedback
jpdjere Mar 18, 2024
826c239
Addressing feedback
jpdjere Mar 18, 2024
d92ebd6
Started fixing concrete diff algorithms section
jpdjere Mar 22, 2024
5ef3901
Fix Numbers algorithm
jpdjere Mar 22, 2024
d38964c
Change
jpdjere Mar 22, 2024
f797266
Add explanation
jpdjere Mar 22, 2024
e44c570
Added references to nodeDiff3
jpdjere Mar 22, 2024
820034e
Cleanup
jpdjere Mar 22, 2024
473c1dc
Fixed Array of strings section
jpdjere Mar 25, 2024
c1e97d5
Fix
jpdjere Mar 25, 2024
01ed741
Fixed 'Array of objects' section
jpdjere Mar 25, 2024
c3c9e7e
Finished correction
jpdjere Mar 25, 2024
bc14d24
Fix TOC
jpdjere Mar 26, 2024
484f977
Address further feedback
jpdjere Mar 27, 2024
8da0a9d
Further fix
jpdjere Mar 27, 2024
e710787
Address feedback
jpdjere Apr 1, 2024
30ac113
Addressed final feedback round
jpdjere Apr 2, 2024
ee72802
Removed test changes
jpdjere Apr 3, 2024
74d4f8d
Other changes reverted
jpdjere Apr 3, 2024
924e393
Add CODEOWNERS
jpdjere Apr 3, 2024
dadbd7d
Merge branch 'main' into rfc-prebuilt-rules-customization
jpdjere Apr 3, 2024
bc67346
Fixes
jpdjere Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1427,6 +1427,7 @@ x-pack/test/security_solution_cypress/cypress/tasks/expandable_flyout @elastic/
/x-pack/plugins/security_solution/common/detection_engine/rule_management @elastic/security-detection-rule-management

/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/docs/rfcs/detection_response @elastic/security-detection-rule-management @elastic/security-detection-engine
/x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/rule_management @elastic/security-detection-rule-management
/x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management @elastic/security-detection-rule-management
Expand Down
Loading