[Security Solution] Added the rule_source field to the rule schemas #181581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcrzx
added
Team:Detections and Resp
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
xcrzx
force-pushed
the
rule-source-schema
branch
4 times, most recently
from
0644a27
to
b552f76
Compare
xcrzx
changed the title
xcrzx
force-pushed
the
rule-source-schema
branch
from
b552f76
to
0fe40ae
Compare
xcrzx
force-pushed
the
rule-source-schema
branch
from
0fe40ae
to
6969bf9
Compare
xcrzx
force-pushed
the
rule-source-schema
branch
from
6969bf9
to
cff3ca9
Compare
xcrzx
force-pushed
the
rule-source-schema
branch
from
cff3ca9
to
23c0db9
Compare
xcrzx
force-pushed
the
rule-source-schema
branch
from
23c0db9
to
2a5cfc0
Compare
ymao1
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Response Ops changes LGTM! This is an addition to the detection rule params schema, so I checked that it follows the guidelines for intermediate release:
✅ - optional field added to the schema
✅ - no changes to actually set the field from the UI.
Please ensure that this PR is merged and released to serverless before any followup PRs that make use of this new field. Please reach out if there are any questions about this process. Thanks!
nikitaindik
reviewed
May 1, 2024
.../server/lib/detection_engine/rule_management/logic/import/create_rules_stream_from_ndjson.ts
Show resolved
Hide resolved
nikitaindik
approved these changes
May 1, 2024
There was a problem hiding this comment.
Thanks for the PR @xcrzx! The changes look good to me. I left one comment. Please take a look when you can.
jpdjere
reviewed
May 2, 2024
...ecurity_solution/common/api/detection_engine/model/rule_schema/common_attributes.schema.yaml
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
…lastic#181581) **Resolves: elastic#180121 **Resolves: elastic#180122 **Resolves: elastic#180124 ## Summary As part of the preparatory changes for the work in Milestone 3, we want to add the new `rule_source` field to the API schema. - Added `rule_source` as an **optional** property to `RuleResponse`, by introducing it as an optional property in the `ResponseFields` schema. - For now, all endpoints should return `undefined` for the `rule_source` field. - Added `rule_source` as an **optional** property to `RuleToImport`, which defines the schema of required and accepted fields when importing a rule. - For now, the new `rule_source` field should be ignored in the endpoint logic. - Added the `ruleSource` field to the `BaseRuleParams` schema, as an optional field. - Implemented a Zod transformation from `snake_case` to `camelCase` for object keys to reduce code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #180121
Resolves: #180122
Resolves: #180124
Summary
As part of the preparatory changes for the work in Milestone 3, we want to add the new
rule_sourcefield to the API schema.rule_sourceas an optional property toRuleResponse, by introducing it as an optional property in theResponseFieldsschema.undefinedfor therule_sourcefield.rule_sourceas an optional property toRuleToImport, which defines the schema of required and accepted fields when importing a rule.rule_sourcefield should be ignored in the endpoint logic.ruleSourcefield to theBaseRuleParamsschema, as an optional field.snake_casetocamelCasefor object keys to reduce code duplication.