Revert "[Fleet] Expand subfields of nested objects when generating template (#191730)" #191897
+9
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplate (elastic#191730)" This reverts commit cdb1eb8.
jsoriano
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jsoriano
added
the
release_note:skip
juliaElastic
approved these changes
Sep 2, 2024
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @jsoriano |
jsoriano
added a commit
to jsoriano/kibana
that referenced
this pull request
Sep 6, 2024
…emplate (elastic#191730)" (elastic#191897) This reverts commit 7cf77b3.
jsoriano
added a commit
that referenced
this pull request
Sep 6, 2024
…emplate (#191730)" (#191897) (#192246) This change was released at the end in 8.15.1, so let's keep it the branch. There are definitions of nested objects whose fields are defined as subfields, like this: ``` - name: a type: nested fields: - name: b type: keyword ``` This should generate a template with the subfields as subproperties: ``` "properties": { ... "a": { "type": "nested", "properties": { "b": { "ignore_above": 1024, "type": "keyword", }, }, }, }, ``` This change adds support for this. Without it the nested object is empty, without subfields, what is unexpected. See elastic/package-spec#784 for more context. This change was originally reverted in 8.15 in #191897 Release notes were manually added in elastic/ingest-docs#1292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cdb1eb8.
It is a bugfix but was not intended to be released in a patch version.