Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases][Flaky Test] Memoize test provider #195088

Merged
merged 4 commits into from
Oct 21, 2024
Merged

[Cases][Flaky Test] Memoize test provider #195088

merged 4 commits into from
Oct 21, 2024

Conversation

jcger
Copy link
Contributor

@jcger jcger commented Oct 4, 2024 •
edited by kibanamachine
Loading

Summary

  • Memo as much as possible in the common component that mocks providers for the component tests in cases.
  • Also fixes an issue with fake jest timers in utility_bar.test

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 4, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #56 / EPM Endpoints installs packages that include settings and mappings overrides should install the overrides package correctly
  • [job] [logs] FTR Configs #56 / EPM Endpoints installs packages that include settings and mappings overrides should install the overrides package correctly
  • [job] [logs] FTR Configs #5 / Maps endpoints apis bsearch ES|QL should return getValues response in expected shape
  • [job] [logs] FTR Configs #5 / Maps endpoints apis bsearch ES|QL should return getValues response in expected shape
  • [job] [logs] Jest Tests #4 / Template fields renders template fields correctly

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jcger jcger added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Oct 18, 2024
@jcger jcger changed the title [Cases] Flaky Test - Another desperate try to fix flakiness in cases [Cases][Flaky Test] Memoize test provider Oct 18, 2024
@jcger jcger marked this pull request as ready for review October 18, 2024 11:21
@jcger jcger requested a review from a team as a code owner October 18, 2024 11:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

js-jankisalvi
js-jankisalvi approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea! 🤞

@jcger jcger enabled auto-merge (squash) October 21, 2024 07:08
@jcger jcger merged commit 498da89 into elastic:main Oct 21, 2024
24 of 25 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https:/elastic/kibana/actions/runs/11436673647

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2024
@jcger
[Cases][Flaky Test] Memoize test provider (elastic#195088)
1475743 
## Summary

- Memo as much as possible in the common component that mocks providers
for the component tests in cases.
- Also fixes an issue with fake jest timers in `utility_bar.test`

(cherry picked from commit 498da89)
@kibanamachine kibanamachine mentioned this pull request Oct 21, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 21, 2024
@kibanamachine @jcger
[8.x] [Cases][Flaky Test] Memoize test provider (#195088) (#197008)
933cbc0 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cases][Flaky Test] Memoize test provider
(#195088)](#195088)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https:/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julian
Gernun","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T08:55:45Z","message":"[Cases][Flaky
Test] Memoize test provider (#195088)\n\n## Summary\r\n\r\n- Memo as
much as possible in the common component that mocks providers\r\nfor the
component tests in cases.\r\n- Also fixes an issue with fake jest timers
in
`utility_bar.test`","sha":"498da89e272b01fa33bf31998d65de2254c9c56c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor"],"title":"[Cases][Flaky
Test] Memoize test provider
","number":195088,"url":"https:/elastic/kibana/pull/195088","mergeCommit":{"message":"[Cases][Flaky
Test] Memoize test provider (#195088)\n\n## Summary\r\n\r\n- Memo as
much as possible in the common component that mocks providers\r\nfor the
component tests in cases.\r\n- Also fixes an issue with fake jest timers
in
`utility_bar.test`","sha":"498da89e272b01fa33bf31998d65de2254c9c56c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https:/elastic/kibana/pull/195088","number":195088,"mergeCommit":{"message":"[Cases][Flaky
Test] Memoize test provider (#195088)\n\n## Summary\r\n\r\n- Memo as
much as possible in the common component that mocks providers\r\nfor the
component tests in cases.\r\n- Also fixes an issue with fake jest timers
in
`utility_bar.test`","sha":"498da89e272b01fa33bf31998d65de2254c9c56c"}}]}]
BACKPORT-->

Co-authored-by: Julian Gernun <[email protected]>
Heenawter pushed a commit to Heenawter/kibana that referenced this pull request Oct 22, 2024
@jcger @Heenawter
[Cases][Flaky Test] Memoize test provider (elastic#195088)
8a671ec 
## Summary

- Memo as much as possible in the common component that mocks providers
for the component tests in cases.
- Also fixes an issue with fake jest timers in `utility_bar.test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

@guskovaue guskovaue guskovaue approved these changes

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jcger @kibana-ci @elasticmachine @kibanamachine @cnasikas @guskovaue @js-jankisalvi