Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index management] Add locator for deep linking into datastreams flyout #195299

Merged

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Oct 7, 2024

Fixes #195083

Summary

This PR adds a url locator that allows consumers to deep link into data streams details flyout.

@sabarasaba sabarasaba added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 7, 2024
@sabarasaba sabarasaba self-assigned this Oct 7, 2024
@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

cc @sabarasaba

@elastic elastic deleted a comment from kibana-ci Oct 7, 2024
@sabarasaba sabarasaba marked this pull request as ready for review October 7, 2024 21:07
@sabarasaba sabarasaba requested a review from a team as a code owner October 7, 2024 21:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@ElenaStoeva ElenaStoeva self-requested a review October 8, 2024 11:31
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @sabarasaba! Code changes lgtm. Is there a way to manually test the added locator in the UI?

@sabarasaba
Copy link
Member Author

Thanks for working on this @sabarasaba! Code changes lgtm. Is there a way to manually test the added locator in the UI?

Thanks for reviewing @ElenaStoeva! Not really since its up to the requesting team to implement, the only way you can do so is by temporarily consuming the locator from another plugin.

Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, thanks for clarifying! We have unit tests so I think we're good.

@sabarasaba sabarasaba merged commit 17ae71b into elastic:main Oct 8, 2024
21 checks passed
neptunian added a commit that referenced this pull request Oct 9, 2024
## Summary

add locator to link to data stream management recently made available
#195299
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
…95433)

## Summary

add locator to link to data stream management recently made available
elastic#195299

(cherry picked from commit ee4815a)
@ElenaStoeva ElenaStoeva added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Oct 14, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https:/elastic/kibana/actions/runs/11327061522

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https:/elastic/kibana/actions/runs/11327061537

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 14, 2024
…s flyout (#195299) (#196123)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Index management] Add locator for deep linking into datastreams
flyout (#195299)](#195299)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https:/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T12:36:55Z","message":"[Index
management] Add locator for deep linking into datastreams flyout
(#195299)","sha":"17ae71b3d9008bc41582c8c92e1c3dadddd2e38b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Index
management] Add locator for deep linking into datastreams
flyout","number":195299,"url":"https:/elastic/kibana/pull/195299","mergeCommit":{"message":"[Index
management] Add locator for deep linking into datastreams flyout
(#195299)","sha":"17ae71b3d9008bc41582c8c92e1c3dadddd2e38b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https:/elastic/kibana/pull/195299","number":195299,"mergeCommit":{"message":"[Index
management] Add locator for deep linking into datastreams flyout
(#195299)","sha":"17ae71b3d9008bc41582c8c92e1c3dadddd2e38b"}}]}]
BACKPORT-->

Co-authored-by: Ignacio Rivas <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 14, 2024
…5433) (#195555)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Data Usage] add locator to link to data stream management
(#195433)](#195433)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https:/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sandra
G","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T09:47:16Z","message":"[Data
Usage] add locator to link to data stream management (#195433)\n\n##
Summary\r\n\r\nadd locator to link to data stream management recently
made
available\r\nhttps://pull/195299","sha":"ee4815a570e4ac1151deec1eb28437ec585411b6","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Data
Usage] add locator to link to data stream
management","number":195433,"url":"https:/elastic/kibana/pull/195433","mergeCommit":{"message":"[Data
Usage] add locator to link to data stream management (#195433)\n\n##
Summary\r\n\r\nadd locator to link to data stream management recently
made
available\r\nhttps://pull/195299","sha":"ee4815a570e4ac1151deec1eb28437ec585411b6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https:/elastic/kibana/pull/195433","number":195433,"mergeCommit":{"message":"[Data
Usage] add locator to link to data stream management (#195433)\n\n##
Summary\r\n\r\nadd locator to link to data stream management recently
made
available\r\nhttps://pull/195299","sha":"ee4815a570e4ac1151deec1eb28437ec585411b6"}}]}]
BACKPORT-->

Co-authored-by: Sandra G <[email protected]>
Co-authored-by: Ash <[email protected]>
Co-authored-by: Yuliia Naumenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create locator for deep linking into index management
4 participants